Issue 8585011: Make html_contents_ in BallonViewImpl scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8585011: Make html_contents_ in BallonViewImpl scoped_ptr. (Closed)

Created:
9 years, 1 month ago by tbarzic

Modified:
9 years, 1 month ago

Reviewers:
oshima

CC:
chromium-reviews, Alexander Potapenko, nkostylev+watch_chromium.org, Timur Iskhodzhanov, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make html_contents_ in BallonViewImpl scoped_ptr. Initially, this object was owned by views hierarchy, but this is not the case since http://src.chromium.org/viewvc/chrome?view=rev&revision=42404. The leak didn't manifest itself until http://src.chromium.org/viewvc/chrome?view=rev&revision=110041 TEST=none BUG=104029 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110460

Patch Set 1 #

Patch Set 2 : will land suppression separately #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/notifications/balloon_view.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/notifications/balloon_view.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8585011/2001

9 years, 1 month ago (2011-11-17 02:02:05 UTC) #3

Change committed as 110460

Expand Messages | Collapse Messages