Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 8585006: Turn app notifications sync to be on by default (Closed)

Created:
9 years, 1 month ago by asargent_no_longer_on_chrome
Modified:
9 years ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Turn app notifications sync to be on by default BUG=96713 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110623

Patch Set 1 #

Patch Set 2 : fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
asargent_no_longer_on_chrome
9 years, 1 month ago (2011-11-16 23:21:47 UTC) #1
Munjal (Google)
lgtm
9 years, 1 month ago (2011-11-16 23:27:27 UTC) #2
lipalani1
LGTM
9 years, 1 month ago (2011-11-17 21:04:26 UTC) #3
lipalani1
BTW AFAIK this feature does not have any integration tests. I think it should be ...
9 years, 1 month ago (2011-11-17 21:12:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8585006/1
9 years, 1 month ago (2011-11-17 21:24:03 UTC) #5
asargent_no_longer_on_chrome
On 2011/11/17 21:12:24, lipalani1 wrote: > BTW AFAIK this feature does not have any integration ...
9 years, 1 month ago (2011-11-17 21:24:19 UTC) #6
commit-bot: I haz the power
Try job failure for 8585006-1 (retry) on linux_rel for step "unit_tests". It's a second try, ...
9 years, 1 month ago (2011-11-17 22:26:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8585006/7001
9 years, 1 month ago (2011-11-17 23:51:47 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 01:31:13 UTC) #9
Change committed as 110623

Powered by Google App Engine
This is Rietveld 408576698