Enable content scripts to receive extension API events.

Enable content scripts to receive extension API events.

BUG=80308
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110472

[Yoyo Zhou, 2011-11-16 23:51:13]

LGTM

Do you need to use an event from an experimental API? It just seems like another
thing that someone needs to remember to fix when it comes out of experimental.

http://codereview.chromium.org/8585005/diff/5001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_event_router.cc (right):

http://codereview.chromium.org/8585005/diff/5001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_event_router.cc:280: if
(ExtensionAPI::GetInstance()->IsPrivileged(event->event_name) &&
Add a comment here to indicate what this check is for.

http://codereview.chromium.org/8585005/diff/5001/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/content_scripts/extension_api/manifest.json
(right):

http://codereview.chromium.org/8585005/diff/5001/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/content_scripts/extension_api/manifest.json:4:
"permissions": ["tabs", "experimental"],
Ouch... Since this wasn't successfully using tabs permissions before, does it
need it now?

[Aaron Boodman, 2011-11-17 07:17:52]

I do need to use settings because it is the only unprivileged API right now.

http://codereview.chromium.org/8585005/diff/5001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_event_router.cc (right):

http://codereview.chromium.org/8585005/diff/5001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_event_router.cc:280: if
(ExtensionAPI::GetInstance()->IsPrivileged(event->event_name) &&
On 2011/11/16 23:51:13, Yoyo Zhou wrote:
> Add a comment here to indicate what this check is for.

Done.

http://codereview.chromium.org/8585005/diff/5001/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/content_scripts/extension_api/manifest.json
(right):

http://codereview.chromium.org/8585005/diff/5001/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/content_scripts/extension_api/manifest.json:4:
"permissions": ["tabs", "experimental"],
On 2011/11/16 23:51:13, Yoyo Zhou wrote:
> Ouch... Since this wasn't successfully using tabs permissions before, does it
> need it now?

Good point, done.

[commit-bot: I haz the power, 2011-11-17 07:19:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/8585005/1006

[commit-bot: I haz the power, 2011-11-17 08:46:06]

Change committed as 110472