Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Unified Diff: ppapi/tests/test_url_loader.cc

Issue 8585003: Test NaCl version of ppapi_tests via ui_tests (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/tests/test_url_loader.cc
===================================================================
--- ppapi/tests/test_url_loader.cc (revision 110336)
+++ ppapi/tests/test_url_loader.cc (working copy)
@@ -87,8 +87,11 @@
RUN_TEST_FORCEASYNC_AND_NOT(BinaryDataPOST, filter);
RUN_TEST_FORCEASYNC_AND_NOT(CustomRequestHeader, filter);
RUN_TEST_FORCEASYNC_AND_NOT(FailsBogusContentLength, filter);
- RUN_TEST_FORCEASYNC_AND_NOT(SameOriginRestriction, filter);
- RUN_TEST_FORCEASYNC_AND_NOT(CrossOriginRequest, filter);
+ // Disable portion of test which failes when the HTTP server's
dmichael (off chromium) 2011/11/18 20:10:25 nit: failes->fails
noelallen1 2011/11/18 20:39:39 Done.
+ // data_dir is moved to PRODUCT_DIR.
+ // http://code.google.com/p/chromium/issues/detail?id=103690
+ // RUN_TEST_FORCEASYNC_AND_NOT(SameOriginRestriction, filter);
+ // RUN_TEST_FORCEASYNC_AND_NOT(CrossOriginRequest, filter);
dmichael (off chromium) 2011/11/18 20:10:25 You should be able to disable these only for NaCl,
noelallen1 2011/11/18 20:39:39 They fail for both trusted and untrusted tests whe
RUN_TEST_FORCEASYNC_AND_NOT(JavascriptURLRestriction, filter);
RUN_TEST_FORCEASYNC_AND_NOT(MethodRestriction, filter);
RUN_TEST_FORCEASYNC_AND_NOT(HeaderRestriction, filter);

Powered by Google App Engine
This is Rietveld 408576698