Test NaCl version of ppapi_tests via ui_tests

Test NaCl version of ppapi_tests via ui_tests

This is a relative path version of:
   http://codereview.chromium.org/8539019
with valgrind tests disabled.

Copy server pieces to build output dir.
Update ppapi_uitests.cc to run server from output dir.
Add test to ppapi_uitests, update dependecies.
Update test_sever to support a fully qualified path.

BUG= http://code.google.com/p/chromium/issues/detail?id=96782
TEST= try (ui_tests --gtest_filter="PPAPI*.*")
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110760

[commit-bot: I haz the power, 2011-11-18 19:08:21]

No comments yet.

[dmichael (off chromium), 2011-11-18 20:10:25]

some nits, o/w LGTM

http://codereview.chromium.org/8585003/diff/2003/chrome/test/ui/ppapi_uitest.cc
File chrome/test/ui/ppapi_uitest.cc (right):

http://codereview.chromium.org/8585003/diff/2003/chrome/test/ui/ppapi_uitest....
chrome/test/ui/ppapi_uitest.cc:70: FilePath exe_dir =
CommandLine::ForCurrentProcess()->GetProgram().DirName();
nit: could you add a comment explaining why you need to run the web server
pointing to a different location? (I assume it's so that it will be able to find
build artifacts like the nmf file and nexes).

http://codereview.chromium.org/8585003/diff/2003/chrome/test/ui/ppapi_uitest....
chrome/test/ui/ppapi_uitest.cc:165: return StringPrintf("%stestcase=%s",
base.c_str(), test_case.c_str());
optional nit: I guess it's fine, but why not just
return base + "testcase=" + test_case;
?
(There's a similar use of StringPrintf below).

http://codereview.chromium.org/8585003/diff/2003/ppapi/tests/test_url_loader.cc
File ppapi/tests/test_url_loader.cc (right):

http://codereview.chromium.org/8585003/diff/2003/ppapi/tests/test_url_loader....
ppapi/tests/test_url_loader.cc:90: // Disable portion of test which failes when
the HTTP server's
nit: failes->fails

http://codereview.chromium.org/8585003/diff/2003/ppapi/tests/test_url_loader....
ppapi/tests/test_url_loader.cc:94: // 
RUN_TEST_FORCEASYNC_AND_NOT(CrossOriginRequest, filter);
You should be able to disable these only for NaCl, right?

[noelallen1, 2011-11-18 20:39:39]

http://codereview.chromium.org/8585003/diff/2003/chrome/test/ui/ppapi_uitest.cc
File chrome/test/ui/ppapi_uitest.cc (right):

http://codereview.chromium.org/8585003/diff/2003/chrome/test/ui/ppapi_uitest....
chrome/test/ui/ppapi_uitest.cc:70: FilePath exe_dir =
CommandLine::ForCurrentProcess()->GetProgram().DirName();
On 2011/11/18 20:10:25, dmichael wrote:
> nit: could you add a comment explaining why you need to run the web server
> pointing to a different location? (I assume it's so that it will be able to
find
> build artifacts like the nmf file and nexes).

Done.

http://codereview.chromium.org/8585003/diff/2003/chrome/test/ui/ppapi_uitest....
chrome/test/ui/ppapi_uitest.cc:165: return StringPrintf("%stestcase=%s",
base.c_str(), test_case.c_str());
On 2011/11/18 20:10:25, dmichael wrote:
> optional nit: I guess it's fine, but why not just
> return base + "testcase=" + test_case;
> ?
> (There's a similar use of StringPrintf below).
Previous comment from other reviewer to use StringPrintf.  :)

http://codereview.chromium.org/8585003/diff/2003/ppapi/tests/test_url_loader.cc
File ppapi/tests/test_url_loader.cc (right):

http://codereview.chromium.org/8585003/diff/2003/ppapi/tests/test_url_loader....
ppapi/tests/test_url_loader.cc:90: // Disable portion of test which failes when
the HTTP server's
On 2011/11/18 20:10:25, dmichael wrote:
> nit: failes->fails

Done.

http://codereview.chromium.org/8585003/diff/2003/ppapi/tests/test_url_loader....
ppapi/tests/test_url_loader.cc:94: // 
RUN_TEST_FORCEASYNC_AND_NOT(CrossOriginRequest, filter);
On 2011/11/18 20:10:25, dmichael wrote:
> You should be able to disable these only for NaCl, right?

They fail for both trusted and untrusted tests when you move the server.   I
felt it was better to always move the server, than conditionally move the server
and have different behavior.