Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: base/shared_memory_android.cc

Issue 8585002: Give base::SharedMemory::CreateAnonymous an executable flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new interface, misc call sites unchanged Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/shared_memory_android.cc
diff --git a/base/shared_memory_android.cc b/base/shared_memory_android.cc
index 72c3a5684455e31cf8e309f28ab4b205bfdf31ef..00231e6b3fc3fe19020ea86c4393a0df4c7e9412 100644
--- a/base/shared_memory_android.cc
+++ b/base/shared_memory_android.cc
@@ -16,12 +16,13 @@ namespace base {
// all the file descriptors from different processes associated with the region
// are closed, the memory buffer will go away.
-bool SharedMemory::CreateNamed(const std::string& name,
- bool open_existing, uint32 size) {
+bool SharedMemory::Create(const SharedMemoryCreateOptions& options) {
DCHECK_EQ(-1, mapped_file_ );
// "name" is just a label in ashmem. It is visible in /proc/pid/maps.
- mapped_file_ = ashmem_create_region(name.c_str(), size);
+ mapped_file_ = ashmem_create_region(options.name == NULL ? "" :
+ options.name.c_str(),
Mark Mentovai 2011/12/01 19:31:16 The formatting here makes it look kind of like the
+ options.size);
if (-1 == mapped_file_) {
DLOG(ERROR) << "Shared memory creation failed";
return false;

Powered by Google App Engine
This is Rietveld 408576698