Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6933)

Unified Diff: chrome/test/automation/dom_element_proxy.h

Issue 8584013: gtest / gmock shouldn't be in the shipping product (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert t_a_p change Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/dom_automation_browsertest.cc ('k') | chrome/test/automation/dom_element_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/dom_element_proxy.h
diff --git a/chrome/test/automation/dom_element_proxy.h b/chrome/test/automation/dom_element_proxy.h
index 97a0b4dfed2bfb738718aa1b4feda627badb1078..d1e1b7150bc8bd1f854145940692033a24f2f18c 100644
--- a/chrome/test/automation/dom_element_proxy.h
+++ b/chrome/test/automation/dom_element_proxy.h
@@ -157,27 +157,11 @@ class DOMElementProxy : public JavaScriptObjectProxy {
// Retrieves the element's visibility. Returns true on success.
bool GetVisibility(bool* visilibity);
- // Asserts that no elements can be found by the given locator method.
- void EnsureFindNoElements(const By& by);
-
- // Asserts that |expected_text| matches all the text in this element. This
- // includes the value of textfields and inputs.
- void EnsureTextMatches(const std::string& expected_text);
-
- // Asserts that |expected_html| matches the element's inner html.
- void EnsureInnerHTMLMatches(const std::string& expected_html);
-
- // Asserts that |expected_name| matches the element's name.
- void EnsureNameMatches(const std::string& expected_name);
-
- // Asserts that |expected_visibility| matches the element's visibility.
- void EnsureVisibilityMatches(bool expected_visibility);
-
- // Asserts that |expected_value| eventually matches the element's value for
+ // Returns if |expected_value| eventually matches the element's value for
// |attribute|. This function will block until the timeout is exceeded, in
// which case it will fail, or until the two values match.
- void EnsureAttributeEventuallyMatches(const std::string& attribute,
- const std::string& expected_value);
+ bool DoesAttributeEventuallyMatch(const std::string& attribute,
+ const std::string& expected_value);
private:
// Gets the element's value for the given type. This is a helper method
« no previous file with comments | « chrome/test/automation/dom_automation_browsertest.cc ('k') | chrome/test/automation/dom_element_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698