Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 8584013: gtest / gmock shouldn't be in the shipping product (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai, tony
CC:
chromium-reviews, Ken Kania, Nirnimesh
Visibility:
Public.

Description

gtest / gmock shouldn't be in the shipping product Remove dependencies from automation on testing libraries that pull in gtest / gmock directly or indirectly. Do this by pulling ASSERTs out of chrome code and putting them into test code instead. Also delete some unused code. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111187

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : git try #

Patch Set 4 : ... #

Patch Set 5 : . #

Patch Set 6 : ffffffffffffff #

Patch Set 7 : FFFFFFFFFFFFFFFFFFFFF #

Patch Set 8 : dom proxy #

Patch Set 9 : browser proxy #

Patch Set 10 : give me an f! give me an f! give me a u! #

Patch Set 11 : -/|\- #

Patch Set 12 : . #

Patch Set 13 : revert t_a_p change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -167 lines) Patch
M chrome/chrome.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 1 2 3 2 chunks +3 lines, -11 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/test/automation/dom_automation_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 15 chunks +64 lines, -27 lines 0 comments Download
M chrome/test/automation/dom_element_proxy.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -19 lines 0 comments Download
M chrome/test/automation/dom_element_proxy.cc View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -38 lines 0 comments Download
M chrome/test/automation/extension_proxy.h View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/test/automation/extension_proxy.cc View 1 2 3 4 5 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/test/automation/extension_proxy_uitest.cc View 1 2 3 4 5 6 4 chunks +41 lines, -22 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
tony, I'm not sure if you're an appropriate reviewer for this. For some reason I ...
9 years, 1 month ago (2011-11-22 06:11:09 UTC) #1
Nico
s/tc@goog/tony@chromium/
9 years, 1 month ago (2011-11-22 06:11:26 UTC) #2
Mark Mentovai
LGTM
9 years, 1 month ago (2011-11-22 17:05:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8584013/12002
9 years, 1 month ago (2011-11-22 17:07:24 UTC) #4
tony
nice!
9 years, 1 month ago (2011-11-22 17:39:06 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 19:10:07 UTC) #6
Change committed as 111187

Powered by Google App Engine
This is Rietveld 408576698