Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8584010: Adding base URL to the frame committed message. (Closed)

Created:
9 years, 1 month ago by Jay Civelli
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Adding base URL to the frame committed message. Adding the base URL to the frame committed message. BUG=None TEST=See browser test RenderViewHostTest.BaseURLParam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111333

Patch Set 1 #

Patch Set 2 : Added missing test file #

Patch Set 3 : Synced #

Patch Set 4 : Synced #

Patch Set 5 : Synced, again... #

Patch Set 6 : Synced and disabled test (to figure-out EOL madness) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A chrome/test/data/google.mht View 1 1 chunk +17 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 2 3 4 5 4 chunks +27 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/frame_navigate_params.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jcivelli
9 years, 1 month ago (2011-11-21 20:03:35 UTC) #1
darin (slow to review)
LGTM
9 years, 1 month ago (2011-11-21 20:38:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8584010/5001
9 years, 1 month ago (2011-11-21 23:54:00 UTC) #3
commit-bot: I haz the power
Presubmit check for 8584010-5001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-21 23:54:03 UTC) #4
jcivelli
John, Could you look at content/public/common/frame_navigate_params.h? (I added a new param)
9 years, 1 month ago (2011-11-21 23:56:32 UTC) #5
jam
lgtm
9 years, 1 month ago (2011-11-22 00:01:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8584010/5001
9 years, 1 month ago (2011-11-22 00:09:01 UTC) #7
commit-bot: I haz the power
Try job failure for 8584010-5001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
9 years, 1 month ago (2011-11-22 01:25:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8584010/5001
9 years, 1 month ago (2011-11-22 01:57:52 UTC) #9
commit-bot: I haz the power
Try job failure for 8584010-5001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
9 years, 1 month ago (2011-11-22 03:11:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8584010/12001
9 years, 1 month ago (2011-11-22 18:51:01 UTC) #11
commit-bot: I haz the power
Try job failure for 8584010-12001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
9 years, 1 month ago (2011-11-22 20:07:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8584010/20002
9 years, 1 month ago (2011-11-23 07:55:56 UTC) #13
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 08:55:59 UTC) #14 
Change committed as 111333

Powered by Google App Engine
This is Rietveld 408576698