Add a check for /SAFESEH in checkbins.py.

Add a check for /SAFESEH in checkbins.py.

Similar to BinScope, checkbins.py will either check for the no SEH bit set in DllCharacteristics or a LOAD_CONFIG entry.

BUG=104188
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111015

[scherkus (not reviewing), 2011-11-21 19:38:30]

maruel: python review
siggi: sanity checking on my /SAFESEH stuff

[M-A Ruel, 2011-11-21 19:58:34]

http://build.chromium.org/p/chromium/builders/Win/builds/8187/steps/check_bin...
tells me checkbins.bat is not used. I vote for deleting it.

lgtm otherwise.

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.bat
File tools/checkbins/checkbins.bat (right):

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.bat#n...
tools/checkbins/checkbins.bat:1: @%~dp0..\..\third_party\python_26\python.exe
%~dp0checkbins.py %*
@python %~dp0checkbins.py %*

should be fine. But it is useful at all?

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.py
File tools/checkbins/checkbins.py (right):

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.py#ne...
tools/checkbins/checkbins.py:1: #!/usr/bin/python
#!/usr/bin/env python

[Sigurður Ásgeirsson, 2011-11-21 20:27:32]

nice - I wasn't aware of these tests.

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.py
File tools/checkbins/checkbins.py (right):

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.py#ne...
tools/checkbins/checkbins.py:75: hasattr(pe, "DIRECTORY_ENTRY_LOAD_CONFIG")):
The load config, if present, also needs to have a non-zero SEHandlerCount and a
non-NULL SEHandlerTable.

you can access the fields by
pe.DIRECTORY_ENTRY_LOAD_CONFIG.struct.SEHandlerCount

[scherkus (not reviewing), 2011-11-21 20:33:57]

checkbins.bat removed

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.py
File tools/checkbins/checkbins.py (right):

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.py#ne...
tools/checkbins/checkbins.py:1: #!/usr/bin/python
On 2011/11/21 19:58:34, Marc-Antoine Ruel wrote:
> #!/usr/bin/env python

Done.

http://codereview.chromium.org/8584009/diff/1/tools/checkbins/checkbins.py#ne...
tools/checkbins/checkbins.py:75: hasattr(pe, "DIRECTORY_ENTRY_LOAD_CONFIG")):
On 2011/11/21 20:27:32, Ruðrugis wrote:
> The load config, if present, also needs to have a non-zero SEHandlerCount and
a
> non-NULL SEHandlerTable.
> 
> you can access the fields by
> pe.DIRECTORY_ENTRY_LOAD_CONFIG.struct.SEHandlerCount

Done.

[Sigurður Ásgeirsson, 2011-11-21 20:35:36]

lgtm