Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: chrome/browser/ui/window_sizer.h

Issue 8584001: Remove unused "maximized" parameter from WindowSizer::GetBrowserWindowBounds(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/window_sizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/window_sizer.h
diff --git a/chrome/browser/ui/window_sizer.h b/chrome/browser/ui/window_sizer.h
index cf57e378df9f32505f01cbc97a28e380784c3378..2dcb4827a704462da430a99f2f22a19a349f06ed 100644
--- a/chrome/browser/ui/window_sizer.h
+++ b/chrome/browser/ui/window_sizer.h
@@ -85,7 +85,6 @@ class WindowSizer {
// Retrieve the persisted bounds of the window. Returns true if there was
// persisted data to retrieve state information, false otherwise.
virtual bool GetPersistentState(gfx::Rect* bounds,
- bool* maximized,
gfx::Rect* work_area) const = 0;
// Retrieve the bounds of the most recent window of the matching type.
@@ -94,20 +93,14 @@ class WindowSizer {
virtual bool GetLastActiveWindowState(gfx::Rect* bounds) const = 0;
};
- // Determines the position, size and maximized state for a window as it is
- // created. This function uses several strategies to figure out optimal size
- // and placement, first looking for an existing active window, then falling
- // back to persisted data from a previous session, finally utilizing a default
+ // Determines the position and size for a window as it is created. This
+ // function uses several strategies to figure out optimal size and placement,
+ // first looking for an existing active window, then falling back to persisted
+ // data from a previous session, finally utilizing a default
// algorithm. If |specified_bounds| are non-empty, this value is returned
// instead. For use only in testing.
- //
- // NOTE: |maximized| is only set if we're restoring a saved maximized window.
- // When creating a new window based on an existing active window, standard
- // Windows behavior is to have it always be nonmaximized, even if the existing
- // window is maximized.
void DetermineWindowBounds(const gfx::Rect& specified_bounds,
- gfx::Rect* bounds,
- bool* maximized) const;
+ gfx::Rect* bounds) const;
// Determines the size, position and maximized state for the browser window.
// See documentation for DetermineWindowBounds above. Normally,
@@ -117,8 +110,7 @@ class WindowSizer {
static void GetBrowserWindowBounds(const std::string& app_name,
const gfx::Rect& specified_bounds,
const Browser* browser,
- gfx::Rect* window_bounds,
- bool* maximized);
+ gfx::Rect* window_bounds);
// Returns the default origin for popups of the given size.
static gfx::Point GetDefaultPopupOrigin(const gfx::Size& size);
@@ -140,7 +132,7 @@ class WindowSizer {
// in local state preferences. Returns true if local state exists containing
// this information, false if this information does not exist and a default
// size should be used.
- bool GetSavedWindowBounds(gfx::Rect* bounds, bool* maximized) const;
+ bool GetSavedWindowBounds(gfx::Rect* bounds) const;
// Gets the default window position and size if there is no last window and
// no saved window placement in prefs. This function determines the default
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/window_sizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698