Implement TRACE_COUNTER

Implement TRACE_COUNTER

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110675

[jbates, 2011-11-16 19:16:17]

lgtm

http://codereview.chromium.org/8579001/diff/1/base/debug/trace_event.h
File base/debug/trace_event.h (right):

http://codereview.chromium.org/8579001/diff/1/base/debug/trace_event.h#newcode44
base/debug/trace_event.h:44: // Sometimes, you want to track two counters at
once. You cand o this with two
s/o/do

[jar (doing other things), 2011-11-16 20:18:41]

LGTM (with tiny typo nit)

...although I'm wondering if some of the macros could be refactored to have
fewer of them.

This is the first time I've looked much at this code, so it may not be an
issue... it was a lot to read.  I couldn't find any use of StringWithCopy() in
the codebase, and wasn't sure how/when it was applicable as well.

http://codereview.chromium.org/8579001/diff/1/base/debug/trace_event.h
File base/debug/trace_event.h (right):

http://codereview.chromium.org/8579001/diff/1/base/debug/trace_event.h#newcode44
base/debug/trace_event.h:44: // Sometimes, you want to track two counters at
once. You cand o this with two
nit: typo: "cand o" --> "can do"

[nduca, 2011-11-18 07:50:13]

On 2011/11/16 20:18:41, jar wrote:
> ...although I'm wondering if some of the macros could be refactored to have
> fewer of them.
> 
> This is the first time I've looked much at this code, so it may not be an
> issue... it was a lot to read.  I couldn't find any use of StringWithCopy() in
> the codebase, and wasn't sure how/when it was applicable as well.

Yeah a great point. You, jbates and I should sit down sometime and go over the
issues.

The copy stuff is used in the downstream branch that shall not be named. :)