Issue 8578010: Print Preview: Fixing crash when hitting tab multiple times.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8578010: Print Preview: Fixing crash when hitting tab multiple times. (Closed)

Created:
9 years, 1 month ago by dpapad

Modified:
9 years, 1 month ago

Reviewers:
Lei Zhang, Avi (use Gerrit)

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Print Preview: Fixing crash when hitting tab multiple times. BUG=104478 TEST=Hit tab mulitple times, browser should not crash, focus should cycle through printing options. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110396

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing typo #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dpapad

This seems to fix the problem. Is it the correct fix though?

9 years, 1 month ago (2011-11-16 17:51:33 UTC) #1

Lei Zhang

LGTM avi: OWNERS review? http://codereview.chromium.org/8578010/diff/1/chrome/browser/tab_contents/tab_contents_view_gtk.cc File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right): http://codereview.chromium.org/8578010/diff/1/chrome/browser/tab_contents/tab_contents_view_gtk.cc#newcode272 chrome/browser/tab_contents/tab_contents_view_gtk.cc:272: // This is called when ...

9 years, 1 month ago (2011-11-16 21:52:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpapad@chromium.org/8578010/5001

9 years, 1 month ago (2011-11-16 21:59:34 UTC) #4

Change committed as 110396

Expand Messages | Collapse Messages