Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 8578002: Add client side protobuf fields for reporting status with policy requests. (Closed)

Created:
9 years, 1 month ago by Patrick Dubroy
Modified:
9 years, 1 month ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Visibility:
Public.

Description

Add client side protobuf fields for reporting status with policy requests. BUG=chromium-os:22036 TEST=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110311

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing status report request fields. #

Patch Set 3 : Remove accidentally uploaded file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -5 lines) Patch
M chrome/browser/policy/proto/device_management_backend.proto View 1 10 chunks +111 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Patrick Dubroy
Joao, can you please take a look at this?
9 years, 1 month ago (2011-11-16 14:52:57 UTC) #1
Joao da Silva
http://codereview.chromium.org/8578002/diff/1/chrome/browser/policy/proto/device_management_backend.proto File chrome/browser/policy/proto/device_management_backend.proto (right): http://codereview.chromium.org/8578002/diff/1/chrome/browser/policy/proto/device_management_backend.proto#newcode332 chrome/browser/policy/proto/device_management_backend.proto:332: optional DevicePolicyRequest policy_request = 3; The StatusReportRequests are missing ...
9 years, 1 month ago (2011-11-16 15:20:31 UTC) #2
Patrick Dubroy
http://codereview.chromium.org/8578002/diff/1/chrome/browser/policy/proto/device_management_backend.proto File chrome/browser/policy/proto/device_management_backend.proto (right): http://codereview.chromium.org/8578002/diff/1/chrome/browser/policy/proto/device_management_backend.proto#newcode332 chrome/browser/policy/proto/device_management_backend.proto:332: optional DevicePolicyRequest policy_request = 3; On 2011/11/16 15:20:31, Joao ...
9 years, 1 month ago (2011-11-16 15:44:41 UTC) #3
Joao da Silva
lgtm
9 years, 1 month ago (2011-11-16 15:52:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/8578002/4004
9 years, 1 month ago (2011-11-16 15:53:52 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 16:53:06 UTC) #6
Change committed as 110311

Powered by Google App Engine
This is Rietveld 408576698