Issue 8576010: Aura: Rewrite FileBrowserNotificationsTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8576010: Aura: Rewrite FileBrowserNotificationsTest (Closed)

Created:
9 years, 1 month ago by James Cook

Modified:
9 years, 1 month ago

Reviewers:
tbarzic

CC:
chromium-reviews, nkostylev+watch_chromium.org, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Aura: Rewrite FileBrowserNotificationsTest Aura uses the views BalloonCollectionImpl, so this rewrites the test to use the generic BalloonCollection interface. The test still fails, but will work when chromeos::SystemNotification is implemented on Aura. BUG=104471 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110441

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -117 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_notifications_browsertest.cc	View	1 2	4 chunks	+133 lines, -117 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tbarzic

9 years, 1 month ago (2011-11-17 01:38:36 UTC) #2

On 2011/11/17 00:57:17, James Cook (Chromium) wrote:
> Toni, please take a look.

LGTM

Expand Messages | Collapse Messages

Issue 8576010: Aura: Rewrite FileBrowserNotificationsTest (Closed)

Description

Patch Set 1 #

Patch Set 2 : updated #

Patch Set 3 : Mark as FAILS on Aura, cleanup #

Messages