Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: ui/aura_shell/shell.cc

Issue 8576005: IME (input method editor) support for Aura, part 3 of 3: Use ui::InputMethod in ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moved IME code to aura_shell, not ready for review though Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura_shell/shell.cc
diff --git a/ui/aura_shell/shell.cc b/ui/aura_shell/shell.cc
index cf55c7bbc1f27e66c63130abbacaa1ed4b6624e5..32f74f3544b1b138a835a3da07c2cb8c96609de5 100644
--- a/ui/aura_shell/shell.cc
+++ b/ui/aura_shell/shell.cc
@@ -9,18 +9,19 @@
#include "ui/aura/aura_switches.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/client/drag_drop_client.h"
-#include "ui/aura/root_window.h"
#include "ui/aura/layout_manager.h"
+#include "ui/aura/root_window.h"
#include "ui/aura/window.h"
#include "ui/aura/window_types.h"
#include "ui/aura_shell/app_list.h"
#include "ui/aura_shell/default_container_event_filter.h"
#include "ui/aura_shell/default_container_layout_manager.h"
-#include "ui/aura_shell/root_window_event_filter.h"
-#include "ui/aura_shell/root_window_layout_manager.h"
#include "ui/aura_shell/drag_drop_controller.h"
+#include "ui/aura_shell/input_method_event_filter.h"
#include "ui/aura_shell/launcher/launcher.h"
#include "ui/aura_shell/modal_container_layout_manager.h"
+#include "ui/aura_shell/root_window_event_filter.h"
+#include "ui/aura_shell/root_window_layout_manager.h"
#include "ui/aura_shell/shadow_controller.h"
#include "ui/aura_shell/shelf_layout_manager.h"
#include "ui/aura_shell/shell_accelerator_controller.h"
@@ -122,6 +123,7 @@ Shell::Shell(ShellDelegate* delegate)
}
Shell::~Shell() {
+ RemoveRootWindowEventFilter(input_method_filter_.get());
RemoveRootWindowEventFilter(accelerator_filter_.get());
// ShellTooltipManager needs a valid shell instance. We delete it before
@@ -234,6 +236,11 @@ void Shell::Init() {
// Force a layout.
root_window_layout->OnWindowResized();
+ // Initialize InputMethodEventFilter. This one must be added first since the
+ // filter has the highest priority.
Ben Goodger (Google) 2011/12/12 16:51:03 To enforce this, you might want to expose a has_ev
Yusuke Sato 2011/12/14 13:42:04 Removed the restriction by adding the new event ty
+ input_method_filter_.reset(new internal::InputMethodEventFilter);
+ AddRootWindowEventFilter(input_method_filter_.get());
+
// Initialize ShellAcceleratorFilter
accelerator_filter_.reset(new internal::ShellAcceleratorFilter);
AddRootWindowEventFilter(accelerator_filter_.get());

Powered by Google App Engine
This is Rietveld 408576698