IME (input method editor) support for Aura, part 3 of 3: Use ui::InputMethod in ash.

views/widget/native_widget_aura.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/native_widget_aura.h"
 
 #include "base/bind.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/desktop.h"
 #include "ui/aura/desktop_observer.h"
 #include "ui/aura/event.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_types.h"
 #include "ui/base/ui_base_types.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/compositor/layer.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/screen.h"
 #include "views/widget/native_widget_delegate.h"
 #include "views/widget/tooltip_manager_views.h"
 
 #if defined(OS_WIN)
 #include "base/win/scoped_gdi_object.h"
 #include "base/win/win_util.h"
 #include "ui/base/l10n/l10n_util_win.h"
 #endif
 
 #if defined(HAVE_IBUS)

[James Su, 2011/11/21 08:23:36]

do we still need this check?

[Yusuke Sato, 2011/11/22 11:09:30]

If we use InputMethodBridge here, views_unittests will fail. It seems that the
unit tests call views::InputMethod's OnFocus() method twice (and therefore,
DCHECK in views::InputMethodBridge::OnFocus fails).

I believe this is a problem in the unit test. I'll file a bug for this issue
later and will put the bug number here.

-#include "ui/views/ime/input_method_ibus.h"
+#include "ui/views/ime/input_method_bridge.h"
 #else
 #include "ui/views/ime/mock_input_method.h"
 #endif
 
 namespace views {
 
 namespace {
 
 aura::WindowType GetAuraWindowTypeForWidgetType(Widget::InitParams::Type type) {
   switch (type) {
@@ skipping 216 matching lines @@
 
 void NativeWidgetAura::ReleaseMouseCapture() {
   window_->ReleaseCapture();
 }
 
 bool NativeWidgetAura::HasMouseCapture() const {
   return window_->HasCapture();
 }
 
 InputMethod* NativeWidgetAura::CreateInputMethod() {
 #if defined(HAVE_IBUS)

[James Su, 2011/11/21 08:23:36]

Do we still need this check?

[Yusuke Sato, 2011/11/22 11:09:30]

ditto.

-  InputMethod* input_method = new InputMethodIBus(this);
+  ui::InputMethod* host = aura::Desktop::GetInstance()->GetInputMethod();
+  InputMethod* input_method = new InputMethodBridge(this, host);
 #else
+  // Use the mock IME for unit tests.
   InputMethod* input_method = new MockInputMethod(this);
 #endif
   input_method->Init(GetWidget());
   return input_method;
 }
 
 void NativeWidgetAura::CenterWindow(const gfx::Size& size) {
   const gfx::Rect parent_bounds = window_->parent()->bounds();
   window_->SetBounds(gfx::Rect((parent_bounds.width() - size.width())/2,
                                (parent_bounds.height() - size.height())/2,
@@ skipping 273 matching lines @@
   Widget* widget = GetWidget();
   if (widget->is_top_level()) {
     InputMethod* input_method = widget->GetInputMethod();
     input_method->OnBlur();
     widget->GetFocusManager()->StoreFocusedView();
   }
   delegate_->OnNativeBlur(NULL);
 }
 
 bool NativeWidgetAura::OnKeyEvent(aura::KeyEvent* event) {
-  // TODO(beng): Need an InputMethodAura to properly handle character events.
-  //             Right now, we just skip these.
-  if (event->is_char())
-    return false;
-
+  DCHECK(!event->is_char());
   DCHECK(window_->IsVisible());
   InputMethod* input_method = GetWidget()->GetInputMethod();
   DCHECK(input_method);
-  // TODO(oshima): DispatchKeyEvent should return bool?
   KeyEvent views_event(event);
   input_method->DispatchKeyEvent(views_event);
   return true;
 }
 
 gfx::NativeCursor NativeWidgetAura::GetCursor(const gfx::Point& point) {
   return cursor_;
 }
 
 int NativeWidgetAura::GetNonClientComponent(const gfx::Point& point) const {
@@ skipping 149 matching lines @@
   NOTIMPLEMENTED();
 }
 
 // static
 bool NativeWidgetPrivate::IsMouseButtonDown() {
   return aura::Desktop::GetInstance()->IsMouseButtonDown();
 }
 
 }  // namespace internal
 }  // namespace views