Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: ui/gfx/render_text.h

Issue 8575020: Improve RenderTextWin font fallback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/render_text.cc » ('j') | ui/gfx/render_text.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.h
===================================================================
--- ui/gfx/render_text.h (revision 111944)
+++ ui/gfx/render_text.h (working copy)
@@ -209,7 +209,7 @@
virtual SelectionModel LeftEndSelectionModel();
virtual SelectionModel RightEndSelectionModel();
- // Get the logical index of the grapheme preceeding the argument |position|.
+ // Get the logical index of the grapheme preceding the argument |position|.
virtual size_t GetIndexOfPreviousGrapheme(size_t position);
// Get the visual bounds containing the logical substring within |from| to
@@ -220,9 +220,12 @@
// TODO(msw) Re-evaluate this function's necessity and signature.
virtual std::vector<Rect> GetSubstringBounds(size_t from, size_t to);
- // Return true if cursor can appear in front of the character at |position|,
- // which means it is a grapheme boundary or the first character in the text.
- virtual bool IsCursorablePosition(size_t position) = 0;
+ // Returns true if the cursor can appear at the specified location, which
+ // means it is a grapheme boundary or the first character in the text. If
+ // |is_trailing| is false, the location specified is in front of the character
+ // at index |position|, otherwise the location corresponds to the end of the
+ // character.
+ virtual bool IsCursorablePosition(size_t position, bool is_trailing) = 0;
msw 2011/11/29 20:42:00 Can this take a SelectionModel::CaretPlacement ins
// Updates the layout so that the next draw request can correctly
// render the text and its attributes.
« no previous file with comments | « no previous file | ui/gfx/render_text.cc » ('j') | ui/gfx/render_text.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698