Improve RenderTextWin font fallback.

ui/views/controls/textfield/textfield_views_model_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/auto_reset.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/string16.h"
@@ skipping 120 matching lines @@
   EXPECT_TRUE(model.Delete());
   EXPECT_EQ(WideToUTF16(L"\x05d0\x05f0\x5f1\x05e0\x05e1\x05e2"),
             model.GetText());
   EXPECT_TRUE(model.Backspace());
   EXPECT_EQ(2U, model.GetCursorPosition());
   EXPECT_EQ(WideToUTF16(L"\x05d0\x05f0\x05e0\x05e1\x05e2"), model.GetText());
 }
 
 TEST_F(TextfieldViewsModelTest, EditString_ComplexScript) {
   TextfieldViewsModel model(NULL);
+
   // Append two Hindi strings.
   model.Append(WideToUTF16(L"\x0915\x093f\x0915\x094d\x0915"));
   EXPECT_EQ(WideToUTF16(L"\x0915\x093f\x0915\x094d\x0915"),
             model.GetText());
   model.Append(WideToUTF16(L"\x0915\x094d\x092e\x094d"));
   EXPECT_EQ(WideToUTF16(
       L"\x0915\x093f\x0915\x094d\x0915\x0915\x094d\x092e\x094d"),
       model.GetText());
 
   // Check it is not able to place cursor in middle of a grapheme.
-  // TODO(xji): temporarily disable in platform Win since the complex script
-  // characters turned into empty square due to font regression. So, not able
-  // to test 2 characters belong to the same grapheme.
-#if defined(OS_LINUX)

[xji, 2011/12/01 08:31:58]

just wondering why those test are enabled but not others?

[Alexei Svitkine (slow), 2011/12/01 18:17:24]

I only enabled the ones that now pass on Windows. I did not investigate why the
others still do not pass, so I've left them disabled with the existing TODO's.

   model.MoveCursorTo(gfx::SelectionModel(1U));
   EXPECT_EQ(0U, model.GetCursorPosition());
-#endif
 
   model.MoveCursorTo(gfx::SelectionModel(2U));
   EXPECT_EQ(2U, model.GetCursorPosition());
   model.InsertChar('a');
   EXPECT_EQ(WideToUTF16(
       L"\x0915\x093f\x0061\x0915\x094d\x0915\x0915\x094d\x092e\x094d"),
       model.GetText());
 
   // ReplaceChar will replace the whole grapheme.
   model.ReplaceChar('b');
@@ skipping 10 matching lines @@
   // Delete should delete the whole grapheme.
   model.MoveCursorTo(gfx::SelectionModel(0U));
   // TODO(xji): temporarily disable in platform Win since the complex script
   // characters turned into empty square due to font regression. So, not able
   // to test 2 characters belong to the same grapheme.
 #if defined(OS_LINUX)
   EXPECT_TRUE(model.Delete());
   EXPECT_EQ(WideToUTF16(L"\x0061\x0062\x0915\x0915\x094d\x092e\x094d"),
             model.GetText());
   model.MoveCursorTo(gfx::SelectionModel(model.GetText().length()));
+  EXPECT_EQ(model.GetText().length(), model.GetCursorPosition());
   EXPECT_TRUE(model.Backspace());
   EXPECT_EQ(WideToUTF16(L"\x0061\x0062\x0915\x0915\x094d\x092e"),
             model.GetText());
 #endif
 
   // Test cursor position and deletion for Hindi Virama.
   model.SetText(WideToUTF16(L"\x0D38\x0D4D\x0D15\x0D16\x0D2E"));
   model.MoveCursorTo(gfx::SelectionModel(0));
   EXPECT_EQ(0U, model.GetCursorPosition());
 
-  // TODO(xji): temporarily disable in platform Win since the complex script
-  // characters turned into empty square due to font regression. So, not able
-  // to test 2 characters belong to the same grapheme.
-#if defined(OS_LINUX)
   model.MoveCursorTo(gfx::SelectionModel(1));
   EXPECT_EQ(0U, model.GetCursorPosition());
-#endif
-
-  model.MoveCursorTo(gfx::SelectionModel(2));
-  EXPECT_EQ(2U, model.GetCursorPosition());
 
   model.MoveCursorTo(gfx::SelectionModel(3));
   EXPECT_EQ(3U, model.GetCursorPosition());
 
+  // TODO(asvitkine): Temporarily disable the following check on Windows. It
+  // seems Windows treats "\x0D38\x0D4D\x0D15" as a single grapheme.
+#if !defined(OS_WIN)
   model.MoveCursorTo(gfx::SelectionModel(2));
-
+  EXPECT_EQ(2U, model.GetCursorPosition());
   EXPECT_TRUE(model.Backspace());
   EXPECT_EQ(WideToUTF16(L"\x0D38\x0D15\x0D16\x0D2E"), model.GetText());
+#endif
 
-  // Test Delete/Backspace on Hebrew with non-spacing marks.
-  // TODO(xji): temporarily disable in platform Win since the complex script
-  // characters turned into empty square due to font regression. So, not able
-  // to test 2 characters belong to the same grapheme.
-#if defined(OS_LINUX)
   model.SetText(WideToUTF16(L"\x05d5\x05b7\x05D9\x05B0\x05D4\x05B4\x05D9"));
   model.MoveCursorTo(gfx::SelectionModel(0));
   EXPECT_TRUE(model.Delete());
   EXPECT_TRUE(model.Delete());
   EXPECT_TRUE(model.Delete());
   EXPECT_TRUE(model.Delete());
   EXPECT_EQ(WideToUTF16(L""), model.GetText());
-#endif
 
   // The first 2 characters are not strong directionality characters.
   model.SetText(WideToUTF16(L"\x002C\x0020\x05D1\x05BC\x05B7\x05E9\x05BC"));
 #if defined(OS_WIN)
   model.MoveCursorRight(gfx::LINE_BREAK, false);
 #else
   model.MoveCursorLeft(gfx::LINE_BREAK, false);
 #endif
   EXPECT_TRUE(model.Backspace());
   EXPECT_EQ(WideToUTF16(L"\x002C\x0020\x05D1\x05BC\x05B7\x05E9"),
@@ skipping 314 matching lines @@
   model.ClearSelection();
   model.MoveCursorRight(gfx::LINE_BREAK, false);
   model.MoveCursorLeft(gfx::WORD_BREAK, true);
   EXPECT_TRUE(model.Paste());
   clipboard->ReadText(ui::Clipboard::BUFFER_STANDARD, &clipboard_text);
   EXPECT_STR_EQ("HELLO HELLO WORLD", clipboard_text);
   EXPECT_STR_EQ("HELLO HELLO HELLO HELLO WORLD", model.GetText());
   EXPECT_EQ(29U, model.GetCursorPosition());
 }
 
-void SelectWordTestVerifier(TextfieldViewsModel &model,
+static void SelectWordTestVerifier(const TextfieldViewsModel& model,
     const string16 &expected_selected_string, size_t expected_cursor_pos) {
   EXPECT_EQ(expected_selected_string, model.GetSelectedText());
   EXPECT_EQ(expected_cursor_pos, model.GetCursorPosition());
 }
 
 TEST_F(TextfieldViewsModelTest, SelectWordTest) {
   TextfieldViewsModel model(NULL);
   model.Append(ASCIIToUTF16("  HELLO  !!  WO     RLD "));
 
   // Test when cursor is at the beginning.
@@ skipping 952 matching lines @@
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCDE", model.GetText());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("1234", model.GetText());
   EXPECT_FALSE(model.Redo());
 
   // TODO(oshima): We need MockInputMethod to test the behavior with IME.
 }
 
 }  // namespace views