Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: chrome/browser/protector/histograms.h

Issue 8575018: Protector histograms for default search provider change added. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/protector/default_search_provider_change.cc ('k') | chrome/browser/protector/histograms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/protector/histograms.h
diff --git a/chrome/browser/protector/histograms.h b/chrome/browser/protector/histograms.h
index e00b814d17f57fd5167c83eb4b792a127259c6a3..c27c379eeee274521458edbe83b8468e8bfb38d7 100644
--- a/chrome/browser/protector/histograms.h
+++ b/chrome/browser/protector/histograms.h
@@ -6,14 +6,19 @@
#define CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_
#pragma once
+class TemplateURL;
+
namespace protector {
// Histogram name to report protection errors for the default search
-// provider.
+// provider. Values are below.
extern const char kProtectorHistogramDefaultSearchProvider[];
+// Histogram value to report that the backup value is invalid or missing.
extern const char kProtectorBackupInvalidCounter[];
+// Histogram value to report that the value does not match the backup.
extern const char kProtectorValueChangedCounter[];
+// Histogram value to report that the value matches the backup.
extern const char kProtectorValueValidCounter[];
// Protector histogram values.
@@ -26,7 +31,22 @@ enum ProtectorError {
kProtectorErrorCount
};
+// Histogram name to report the new default search provider.
+extern const char kProtectorHistogramNewSearchProvider[];
+// Histogram name to report when user accepts new default search provider.
+extern const char kProtectorHistogramSearchProviderApplied[];
+// Histogram name to report when user keeps previous default search provider.
+extern const char kProtectorHistogramSearchProviderDiscarded[];
+// Histogram name to report when user ignores search provider change.
+extern const char kProtectorHistogramSearchProviderTimeout[];
+
+// Returns index to be used in histograms for given search provider (which may
+// be NULL, in which case a special index will be returned).
+int GetSearchProviderHistogramID(const TemplateURL* t_url);
+
+// Maximum value of search provider index in histogram enums.
+extern const int kProtectorMaxSearchProviderID;
+
} // namespace protector
#endif // CHROME_BROWSER_PROTECTOR_HISTOGRAMS_H_
-
« no previous file with comments | « chrome/browser/protector/default_search_provider_change.cc ('k') | chrome/browser/protector/histograms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698