Issue 8575011: chrome: bluetooth: create BluetoothManager after about:flags parsed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8575011: chrome: bluetooth: create BluetoothManager after about:flags parsed (Closed)

Created:
9 years, 1 month ago by Vince Laviano

Modified:
9 years, 1 month ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, kevers

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome: bluetooth: create BluetoothManager after about:flags parsed This CL fixes a crash that occurs if --enable-bluetooth is set via the chrome://flags page. The UI attempts to interact with the BluetoothManager, but neither the BluetoothManager nor the underlying bluetooth dbus clients have been created because the parsed command line was tested for --enable-bluetooth prior to the about:flags flags being added to it. We resolve this issue by unconditionally creating the bluetooth dbus clients and deferring conditional creation of the BluetoothManager until after the about:flags flags are added to the parsed command line. BUG=chromium-os:22877 TEST=Visit chrome://flags. Enable bluetooth. Restart. Visit chrome://settings/system and observe that Chrome doesn't crash. Change-Id: Ib5deed32200afa8c1e9455abc72cefb7e5183da2 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110375

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View		2 chunks	+10 lines, -5 lines	0 comments	Download
	M	chrome/browser/chromeos/dbus/dbus_thread_manager.cc	View		1 chunk	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vlaviano@chromium.org/8575011/1

9 years, 1 month ago (2011-11-16 21:23:50 UTC) #3

Change committed as 110375

Expand Messages | Collapse Messages