Test for immutable Lists in ListSet API methods.

runtime/bin/socket.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/socket.h"
 #include "bin/dartutils.h"
 
 #include "include/dart_api.h"
 
 
@@ skipping 40 matching lines @@
 
   if (Dart_IsVMFlagSet("short_socket_read")) {
     length = (length + 1) / 2;
   }
 
   uint8_t* buffer = new uint8_t[length];
   intptr_t bytes_read = Socket::Read(socket, buffer, length);
   if (bytes_read > 0) {
     Dart_Handle result =
         Dart_ListSetAsBytes(buffer_obj, offset, buffer, bytes_read);
-    ASSERT(!Dart_IsError(result));
+    if (Dart_IsError(result)) {

[turnidge, 2011/11/16 18:50:18]

Diito previous comment.

+      bytes_read = -1;
+    }
   } else if (bytes_read < 0) {
     bytes_read = 0;
   }
   delete[] buffer;
   Dart_SetReturnValue(args, Dart_NewInteger(bytes_read));
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_WriteList)(Dart_NativeArguments args) {
@@ skipping 79 matching lines @@
                                          DartUtils::kIdFieldName);
   Dart_Handle socketobj = Dart_GetNativeArgument(args, 1);
   intptr_t newSocket = ServerSocket::Accept(socket);
   if (newSocket >= 0) {
     DartUtils::SetIntegerInstanceField(
         socketobj, DartUtils::kIdFieldName, newSocket);
   }
   Dart_SetReturnValue(args, Dart_NewBoolean(newSocket >= 0));
   Dart_ExitScope();
 }