Test for immutable Lists in ListSet API methods.

runtime/bin/file.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/file.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
 
 #include "include/dart_api.h"
@@ skipping 141 matching lines @@
     ASSERT((offset + length) <= array_len);
     uint8_t* buffer = new uint8_t[length];
     int total_bytes_read =
         file->Read(reinterpret_cast<void*>(buffer), length);
     /*
      * Reading 0 indicates end of file.
      */
     if (total_bytes_read >= 0) {
       result =
           Dart_ListSetAsBytes(buffer_obj, offset, buffer, total_bytes_read);
-      ASSERT(!Dart_IsError(result));
-      return_value = total_bytes_read;
+      if (!Dart_IsError(result)) {
+        return_value = total_bytes_read;

[turnidge, 2011/11/16 18:50:18]

There's probably some good diagnostic information for the user in
Dart_GetError(result).  Perhaps not useful in this case though.  Up to you.

+      }
     }
     delete[] buffer;
   }
   Dart_SetReturnValue(args, Dart_NewInteger(return_value));
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(File_WriteList)(Dart_NativeArguments args) {
   Dart_EnterScope();
@@ skipping 84 matching lines @@
   Dart_EnterScope();
   const char* str =
       DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));
   char* path = File::GetCanonicalPath(str);
   if (path != NULL) {
     Dart_SetReturnValue(args, Dart_NewString(path));
     free(path);
   }
   Dart_ExitScope();
 }