Issue 8575002: Avoid checking the hardware from the Construct test for better bot compatibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8575002: Avoid checking the hardware from the Construct test for better bot compatibility. (Closed)

Created:
9 years, 1 month ago by tommi (sloooow) - chröme

Modified:
9 years, 1 month ago

Reviewers:
henrika_dont_use, henrika (OOO until Aug 14)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Avoid checking the hardware from the Construct test for better bot compatibility. TEST=This is a preventative fix to avoid flakiness down the line. Currently the test doesn't fail, but it will fail once pending patches are landed. TBR=henrika Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110280

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	content/renderer/media/webrtc_audio_device_unittest.cc	View		2 chunks	+24 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

henrika (OOO until Aug 14)

9 years, 1 month ago (2011-11-16 09:57:58 UTC) #2

LGTM w/ nit.

Perhaps a good idea to add a comment at first test explaining what is so special
with it that we don't check for headless.

http://codereview.chromium.org/8575002/diff/1/content/renderer/media/webrtc_a...
File content/renderer/media/webrtc_audio_device_unittest.cc (right):

http://codereview.chromium.org/8575002/diff/1/content/renderer/media/webrtc_a...
content/renderer/media/webrtc_audio_device_unittest.cc:44: :
output_rate_(output_rate), input_rate_(input_rate) {
add two more spaces?

Expand Messages | Collapse Messages