Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 8574079: Views: Override GetInitiallyFocusedView() for ConstrainedHtmlDelegateViews. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Views: Override GetInitiallyFocusedView() for ConstrainedHtmlDelegateViews. BUG=104588 TEST=manual, see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110634

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/ui/views/constrained_html_delegate_views.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-17 22:59:09 UTC) #1
Evan Stade
looks fine to me but I'm not an owner
9 years, 1 month ago (2011-11-17 23:11:26 UTC) #2
Lei Zhang
+sky for OWNERS
9 years, 1 month ago (2011-11-17 23:22:45 UTC) #3
sky
LGTM
9 years, 1 month ago (2011-11-17 23:31:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8574079/1
9 years, 1 month ago (2011-11-17 23:33:44 UTC) #5
commit-bot: I haz the power
Try job failure for 8574079-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-18 00:38:59 UTC) #6
Lei Zhang
Fixed typo. s/Views/View/
9 years, 1 month ago (2011-11-18 00:42:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8574079/7001
9 years, 1 month ago (2011-11-18 00:43:35 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 01:57:51 UTC) #9
Change committed as 110634

Powered by Google App Engine
This is Rietveld 408576698