Add reload button.

Add reload link.

BUG=chromium:101618
TEST=Load a page.  Open Tools -> Task manager and kill the process for rendering the page.  On the killed process page, click on the "Reload" button.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111159

[kevers, 2011-11-21 17:42:49]

Hi Peter,

Can you please review this change.

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
File chrome/browser/ui/views/sad_tab_view.cc (left):

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:69: help_url, GURL(), CURRENT_TAB,
content::PAGE_TRANSITION_LINK);
This version of OpenURL has been deprecated.  Since I was in the neighborhood, I
updated the call.

[Peter Kasting, 2011-11-21 21:31:05]

LGTM

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
File chrome/browser/ui/views/sad_tab_view.cc (right):

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:64: if (tab_contents_ == NULL)
Honestly, can we ever create a SadTabView() with a NULL TabContents*?  If not we
can DCHECK that in the constructor and eliminate any other conditionals or
DCHECKs.

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:86: views::Button* source,
Nit: Move to previous line, align next arg

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:88: if (tab_contents_ == NULL)
Nit: We only add the reload button if |tab_contents_| is non-NULL, so this
function should be:

  DCHECK(tab_contents_);
  DCHECK(source == reload_button_);
  tab_contents_->controller().Reload(true);

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:136: reload_button_ = CreateButton(
Nit: Since this function is only called once, inline it here.

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
File chrome/browser/ui/views/sad_tab_view.h (right):

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.h:55: virtual void ButtonPressed(
Nit: Wrap like this:

  virtual void ButtonPressed(views::Button* source,
                             const views::Event& event) OVERRIDE;

[kevers, 2011-11-22 13:52:02]

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
File chrome/browser/ui/views/sad_tab_view.cc (right):

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:64: if (tab_contents_ == NULL)
On 2011/11/21 21:31:06, Peter Kasting wrote:
> Honestly, can we ever create a SadTabView() with a NULL TabContents*?  If not
we
> can DCHECK that in the constructor and eliminate any other conditionals or
> DCHECKs.

Done.

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:86: views::Button* source,
On 2011/11/21 21:31:06, Peter Kasting wrote:
> Nit: Move to previous line, align next arg

Done.

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:88: if (tab_contents_ == NULL)
On 2011/11/21 21:31:06, Peter Kasting wrote:
> Nit: We only add the reload button if |tab_contents_| is non-NULL, so this
> function should be:
> 
>   DCHECK(tab_contents_);
>   DCHECK(source == reload_button_);
>   tab_contents_->controller().Reload(true);

Done.

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.cc:136: reload_button_ = CreateButton(
On 2011/11/21 21:31:06, Peter Kasting wrote:
> Nit: Since this function is only called once, inline it here.

Done.

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
File chrome/browser/ui/views/sad_tab_view.h (right):

http://codereview.chromium.org/8574074/diff/2001/chrome/browser/ui/views/sad_...
chrome/browser/ui/views/sad_tab_view.h:55: virtual void ButtonPressed(
On 2011/11/21 21:31:06, Peter Kasting wrote:
> Nit: Wrap like this:
> 
>   virtual void ButtonPressed(views::Button* source,
>                              const views::Event& event) OVERRIDE;

Done.

[commit-bot: I haz the power, 2011-11-22 14:38:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/8574074/10001

[commit-bot: I haz the power, 2011-11-22 15:43:08]

Change committed as 111159