Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 8574070: Move enabling IPC logging for all child processes to the Content API. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | chrome/browser/ui/cocoa/about_ipc_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
===================================================================
--- chrome/browser/browser_process_impl.cc (revision 110645)
+++ chrome/browser/browser_process_impl.cc (working copy)
@@ -68,7 +68,6 @@
#include "chrome/common/switch_utils.h"
#include "chrome/common/url_constants.h"
#include "chrome/installer/util/google_update_constants.h"
-#include "content/browser/browser_child_process_host.h"
#include "content/browser/browser_process_sub_thread.h"
#include "content/browser/child_process_security_policy.h"
#include "content/browser/debugger/devtools_manager.h"
@@ -84,7 +83,6 @@
#include "content/public/browser/notification_details.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/common/url_fetcher.h"
-#include "ipc/ipc_logging.h"
#include "net/socket/client_socket_pool_manager.h"
#include "net/url_request/url_request_context_getter.h"
#include "ui/base/clipboard/clipboard.h"
@@ -96,10 +94,6 @@
#include "chrome/browser/chrome_browser_main_mac.h"
#endif
-#if defined(IPC_MESSAGE_LOG_ENABLED)
-#include "content/common/child_process_messages.h"
-#endif
-
#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/web_socket_proxy_controller.h"
#include "chrome/browser/oom_priority_manager.h"
@@ -1058,49 +1052,6 @@
resource_dispatcher_host()->set_allow_cross_origin_auth_prompt(value);
}
-// The BrowserProcess object must outlive the file thread so we use traits
-// which don't do any management.
-DISABLE_RUNNABLE_METHOD_REFCOUNT(BrowserProcessImpl);
-
-#if defined(IPC_MESSAGE_LOG_ENABLED)
-
-void BrowserProcessImpl::SetIPCLoggingEnabled(bool enable) {
- // First enable myself.
- if (enable)
- IPC::Logging::GetInstance()->Enable();
- else
- IPC::Logging::GetInstance()->Disable();
-
- // Now tell subprocesses. Messages to ChildProcess-derived
- // processes must be done on the IO thread.
- io_thread()->message_loop()->PostTask
- (FROM_HERE,
- NewRunnableMethod(
- this,
- &BrowserProcessImpl::SetIPCLoggingEnabledForChildProcesses,
- enable));
-
- // Finally, tell the renderers which don't derive from ChildProcess.
- // Messages to the renderers must be done on the UI (main) thread.
- for (content::RenderProcessHost::iterator i(
- content::RenderProcessHost::AllHostsIterator());
- !i.IsAtEnd(); i.Advance())
- i.GetCurrentValue()->Send(new ChildProcessMsg_SetIPCLoggingEnabled(enable));
-}
-
-// Helper for SetIPCLoggingEnabled.
-void BrowserProcessImpl::SetIPCLoggingEnabledForChildProcesses(bool enabled) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-
- BrowserChildProcessHost::Iterator i; // default constr references a singleton
- while (!i.Done()) {
- i->Send(new ChildProcessMsg_SetIPCLoggingEnabled(enabled));
- ++i;
- }
-}
-
-#endif // IPC_MESSAGE_LOG_ENABLED
-
// Mac is currently not supported.
#if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | chrome/browser/ui/cocoa/about_ipc_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698