Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 8574070: Move enabling IPC logging for all child processes to the Content API. (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Move enabling IPC logging for all child processes to the Content API. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110747

Patch Set 1 #

Patch Set 2 : fix mac #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -81 lines) Patch
M chrome/browser/browser_process.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 2 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 4 chunks +0 lines, -49 lines 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_controller.mm View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_controller_unittest.mm View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
A content/browser/content_ipc_logging.cc View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A content/public/browser/content_ipc_logging.h View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 1 month ago (2011-11-17 20:39:09 UTC) #1
Dirk Pranke
9 years, 1 month ago (2011-11-17 22:02:49 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698