Mac Panels interaction with Dock modifications. (step 1)

Mac Panels interaction with Dock modifications. (step 1)
1. Drop panels to the bottom edge of screen
2. Make then on top of the Dock

Also, change animation speed calc to make panels 'snappier'. That should make transition from 'minimized' to 'title-only' quite faster.
Add threshold for mouse drag that actually starts drag operation. This should remove spontaneous 'fail to minimize' effect.

BUG=104537, 103095
TEST=Observe Panels on top of Dock, minimize them as needed.




Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110663

[jennb, 2011-11-17 23:45:40]

Any way to test this? If not, could you add manual instructions to a TEST= line?
Thx.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
File chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm (right):

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:30: const int
kDragThreasholdSquared = 9;
typo: Threshold

What's the logic behind using the square of the distance?

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:335: -
(BOOL)overDragThreshold:(NSPoint)mouseLocation {
exceedsDragThreshold? I'm not sure what overDragThreshold means.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:338: return deltaX*deltaX
+ deltaY*deltaY > kDragThreasholdSquared;
Please use parens rather than dropping the spacing around operators if you want
to make precedence more obvious.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:361: if ([self
overDragThreshold:[event locationInWindow]])
nit: How about reversing this conditional to make code easier to read?

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:379: return;
nit: I want to drop this return and add else clause around the last 2 lines.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:43: const double
kBoundsChangeAnimationSpeed = 1000;  // Pixels per second.
Prefer units in var name. kBoundsAnimationPixelsPerSec? kBoundsAnimationMaxSecs?

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:115: [window
setLevel:NSStatusWindowLevel];
I'm assuming the comment no longer applies because we hacked notifications to
always display above panels?

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:447: // specific
well-percieved time, while making smaller updates quicker, which
perceived

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:447: // specific
well-percieved time, while making smaller updates quicker, which
Did you mean slower instead of quicker? (I admit to having trouble parsing this
comment.)

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:449: // 'distance' is
the max travel  between 4 potentially traveling corners.
extra space in line

[Dmitry Titov, 2011-11-18 00:15:11]

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
File chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm (right):

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:30: const int
kDragThreasholdSquared = 9;
On 2011/11/17 23:45:40, jennb wrote:
> typo: Threshold
> 
> What's the logic behind using the square of the distance?

I'm computing a distance and don't want to do sqrt...

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:335: -
(BOOL)overDragThreshold:(NSPoint)mouseLocation {
On 2011/11/17 23:45:40, jennb wrote:
> exceedsDragThreshold? I'm not sure what overDragThreshold means.

Done.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:338: return deltaX*deltaX
+ deltaY*deltaY > kDragThreasholdSquared;
On 2011/11/17 23:45:40, jennb wrote:
> Please use parens rather than dropping the spacing around operators if you
want
> to make precedence more obvious.

Done.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:361: if ([self
overDragThreshold:[event locationInWindow]])
On 2011/11/17 23:45:40, jennb wrote:
> nit: How about reversing this conditional to make code easier to read?

Done.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:379: return;
On 2011/11/17 23:45:40, jennb wrote:
> nit: I want to drop this return and add else clause around the last 2 lines.

Done.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:43: const double
kBoundsChangeAnimationSpeed = 1000;  // Pixels per second.
On 2011/11/17 23:45:40, jennb wrote:
> Prefer units in var name. kBoundsAnimationPixelsPerSec?
kBoundsAnimationMaxSecs?

Done.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:115: [window
setLevel:NSStatusWindowLevel];
On 2011/11/17 23:45:40, jennb wrote:
> I'm assuming the comment no longer applies because we hacked notifications to
> always display above panels?

It never actually applied because it was a copy-paste from Notifications code
and this specific fix was there to fix interaction with Spotlight window. I
initially moved this constant here because it is a better choice in general
(what if a panel will overlap with Spotlight popout?) but now that we want to be
on top of the Dock the more traditional recommendation of using
ModalPanelWindowLevel for always-on-top works better.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:447: // specific
well-percieved time, while making smaller updates quicker, which
On 2011/11/17 23:45:40, jennb wrote:
> perceived

Done.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:447: // specific
well-percieved time, while making smaller updates quicker, which
On 2011/11/17 23:45:40, jennb wrote:
> Did you mean slower instead of quicker? (I admit to having trouble parsing
this
> comment.)

Re-worded, made shorter.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:447: // specific
well-percieved time, while making smaller updates quicker, which
On 2011/11/17 23:45:40, jennb wrote:
> perceived

Done.

http://codereview.chromium.org/8574068/diff/5001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:449: // 'distance' is
the max travel  between 4 potentially traveling corners.
On 2011/11/17 23:45:40, jennb wrote:
> extra space in line

Done.

[jennb, 2011-11-18 00:36:55]

LGTM

http://codereview.chromium.org/8574068/diff/15001/chrome/browser/ui/panels/pa...
File chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm (right):

http://codereview.chromium.org/8574068/diff/15001/chrome/browser/ui/panels/pa...
chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm:338: return deltaX >
kDragThreshold || deltaY > kDragThreshold;
So much simpler! Shaves a few cycles, too. :-D

[commit-bot: I haz the power, 2011-11-18 02:00:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dimich@chromium.org/8574068/15001

[commit-bot: I haz the power, 2011-11-18 04:10:39]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2011-11-18 04:46:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dimich@chromium.org/8574068/15001

[commit-bot: I haz the power, 2011-11-18 05:50:35]

Change committed as 110663