Issue 8574058: Add version of x64 FastCloneShallowArrayStub that copies all boilerplate kinds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8574058: Add version of x64 FastCloneShallowArrayStub that copies all boilerplate kinds (Closed)

Created:
9 years, 1 month ago by danno

Modified:
9 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add version of x64 FastCloneShallowArrayStub that copies all boilerplate kinds R=jkummerow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=10022

Patch Set 1 #

Patch Set 2 : correct diff #

Total comments: 3

Patch Set 3 : review feedback #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -66 lines)			Patch
M	src/ia32/code-stubs-ia32.cc	View	1 2	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2	3 chunks	+86 lines, -48 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2	3 chunks	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years, 1 month ago (2011-11-17 14:34:19 UTC) #2

LGTM with comments.

http://codereview.chromium.org/8574058/diff/1001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8574058/diff/1001/src/ia32/code-stubs-ia32.cc#...
src/ia32/code-stubs-ia32.cc:241: // [esp + kPointerSize]: constant elements.
Same as for the x64 version, I don't see why the details of the stack layout are
relevant for this method.

http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:227: // Stack layout and register on entry:
I don't think the ...Common() method cares about the stack layout.

http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:353: CLONE_DOUBLE_ELEMENTS, &slow_case);
s/CLONE_DOUBLE_ELEMENTS/mode/ !

Expand Messages | Collapse Messages