Chromium Code Reviews

Issue 8574058: Add version of x64 FastCloneShallowArrayStub that copies all boilerplate kinds (Closed)

Created:
9 years, 1 month ago by danno
Modified:
9 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add version of x64 FastCloneShallowArrayStub that copies all boilerplate kinds R=jkummerow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=10022

Patch Set 1 #

Patch Set 2 : correct diff #

Total comments: 3

Patch Set 3 : review feedback #

Unified diffs Side-by-side diffs Stats (+102 lines, -66 lines)
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -6 lines 0 comments
M src/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments
M src/x64/code-stubs-x64.cc View 3 chunks +86 lines, -48 lines 0 comments
M src/x64/full-codegen-x64.cc View 3 chunks +10 lines, -12 lines 0 comments

Messages

Total messages: 2 (0 generated)
danno
PTAL
9 years, 1 month ago (2011-11-17 14:20:28 UTC) #1
Jakob Kummerow
9 years, 1 month ago (2011-11-17 14:34:19 UTC) #2
LGTM with comments.

http://codereview.chromium.org/8574058/diff/1001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8574058/diff/1001/src/ia32/code-stubs-ia32.cc#...
src/ia32/code-stubs-ia32.cc:241: // [esp + kPointerSize]: constant elements.
Same as for the x64 version, I don't see why the details of the stack layout are
relevant for this method.

http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:227: // Stack layout and register on entry:
I don't think the ...Common() method cares about the stack layout.

http://codereview.chromium.org/8574058/diff/1001/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:353: CLONE_DOUBLE_ELEMENTS, &slow_case);
s/CLONE_DOUBLE_ELEMENTS/mode/ !

Powered by Google App Engine