Issue 8574054: Replace FileManagerUtil class with namespace file_manager_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8574054: Replace FileManagerUtil class with namespace file_manager_util. (Closed)

Created:
9 years, 1 month ago by achuithb

Modified:
9 years, 1 month ago

Reviewers:
James Cook

CC:
chromium-reviews, asanka, hclam+watch_chromium.org, nkostylev+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Randy Smith (Not in Mondays), annacc+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), stevenjb+watch_chromium.org, davemoore+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Replace FileManagerUtil class with namespace file_manager_util. file_manager_util namespace is consistent with other utils in the codebase (platform_util, mime_util, file_util), and is the preferred way in the google style guide to do this kind of thing. The FileManagerUtil class is never initialized and has no state. BUG=None, cleanup TEST=Compiles, tests pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110600

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -114 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/media/media_player.cc	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_api.cc	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/file_manager_util.h	View	1	1 chunk	+29 lines, -35 lines	0 comments	Download
M	chrome/browser/extensions/file_manager_util.cc	View	1	7 chunks	+47 lines, -53 lines	0 comments	Download
M	chrome/browser/platform_util_chromeos.cc	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/select_file_dialog_extension.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/active_downloads_ui.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

achuithb

Just some cleanup - no functional change. Please review, James

9 years, 1 month ago (2011-11-17 21:29:37 UTC) #1

LGTM.  Nice cleanup!

Expand Messages | Collapse Messages