Issue 8574053: Add ia32 FastCloneShallowArrayStub that copies all boilerplate kinds.

Issue 8574053: Add ia32 FastCloneShallowArrayStub that copies all boilerplate kinds. (Closed)

Created:
9 years, 1 month ago by danno

Modified:
9 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add ia32 FastCloneShallowArrayStub that copies all boilerplate kinds. R=jkummerow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=10021

Patch Set 2 : review feedback #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -64 lines)			Patch
M	src/code-stubs.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	3 chunks	+86 lines, -46 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	3 chunks	+8 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comments. http://codereview.chromium.org/8574053/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/8574053/diff/1/src/ia32/code-stubs-ia32.cc#newcode237 src/ia32/code-stubs-ia32.cc:237: FastCloneShallowArrayStub::Mode mode, Just to be explicit, ...

9 years, 1 month ago (2011-11-17 12:31:36 UTC) #2

danno

9 years, 1 month ago (2011-11-17 13:51:23 UTC) #3

feedback addressed. landing.

http://codereview.chromium.org/8574053/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8574053/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:237: FastCloneShallowArrayStub::Mode mode,
On 2011/11/17 12:31:36, Jakob wrote:
> Just to be explicit, please add an ASSERT(mode !=
> FastCloneShallowArrayStub::CLONE_ANY_ELEMENTS);

Done.

http://codereview.chromium.org/8574053/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (left):

http://codereview.chromium.org/8574053/diff/1/src/ia32/full-codegen-ia32.cc#o...
src/ia32/full-codegen-ia32.cc:1495: __
IncrementCounter(isolate()->counters()->cow_arrays_created_stub(), 1);
On 2011/11/17 12:31:36, Jakob wrote:
> This line got lost in the refactoring. Care to put it back in?

Done.

Expand Messages | Collapse Messages