[Aura] Fix HtmlDialogBrowserTest.SizeWindow.

[Aura] Fix HtmlDialogBrowserTest.SizeWindow.

- Fix HtmlDialogBrowserTest.SizeWindow for Linux + Aura + Chromeos==0.
- Remove minimum_size_ from auralWindow and add an OnBoundsChanging to aura::WindowDelegate so that a delegate can apply bounds constriant;
- NativeWidgetAura uses OnBoundsChanging to apply Widget's minimum size;
- Remove minimum_size_ member from Widget because it is only used for widget with no frame (i.e. no non_client_view_) and such widget should have no minimum size;

BUG=104412
TEST=Verify the HtmlDialogBrowserTest.SizeWindow should pass for Linux + Aura + Chromeos==0.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110608

[xiyuan, 2011-11-17 00:48:34]

Ben, I hope I get you right. :)

Please take a look. Thanks.

[Ben Goodger (Google), 2011-11-17 20:50:15]

http://codereview.chromium.org/8574049/diff/1015/chrome/browser/ui/views/html...
File chrome/browser/ui/views/html_dialog_view_browsertest.cc (right):

http://codereview.chromium.org/8574049/diff/1015/chrome/browser/ui/views/html...
chrome/browser/ui/views/html_dialog_view_browsertest.cc:51: if
(should_quit_on_size_change_ && last_size_ != bounds.size()) {
I guess this is less hacky than it was before... but still.

http://codereview.chromium.org/8574049/diff/1015/views/widget/widget.cc
File views/widget/widget.cc (left):

http://codereview.chromium.org/8574049/diff/1015/views/widget/widget.cc#oldco...
views/widget/widget.cc:921: return non_client_view_ ?
non_client_view_->GetMinimumSize() : minimum_size_;
Isn't this still required for other NativeWidget impls?

[Ben Goodger (Google), 2011-11-17 21:36:30]

Xiyuan explained the other platform situation. LGTM.

[xiyuan, 2011-11-17 22:05:42]

Just for the record. :)

http://codereview.chromium.org/8574049/diff/1015/chrome/browser/ui/views/html...
File chrome/browser/ui/views/html_dialog_view_browsertest.cc (right):

http://codereview.chromium.org/8574049/diff/1015/chrome/browser/ui/views/html...
chrome/browser/ui/views/html_dialog_view_browsertest.cc:51: if
(should_quit_on_size_change_ && last_size_ != bounds.size()) {
On 2011/11/17 20:50:15, Ben Goodger (Google) wrote:
> I guess this is less hacky than it was before... but still.

Yeah. I'll add a TODO comment to update this when WidgetDelegate is updated to
have bounds change hook. Right now, it has OnWidgeMove,
OnWindowBeginUserBoundsChange etc and does not have a hook for bounds
changing/changed.

http://codereview.chromium.org/8574049/diff/1015/views/widget/widget.cc
File views/widget/widget.cc (left):

http://codereview.chromium.org/8574049/diff/1015/views/widget/widget.cc#oldco...
views/widget/widget.cc:921: return non_client_view_ ?
non_client_view_->GetMinimumSize() : minimum_size_;
On 2011/11/17 20:50:15, Ben Goodger (Google) wrote:
> Isn't this still required for other NativeWidget impls?

Besides NativeWidgetAura, only NativeWidgetWin uses this in its OnGetMinMaxInfo
handler. That handler is called when user resizes a window. So it only happens
for top-level window that has a frame. And thus, non_client_view_ code path will
be used.

[commit-bot: I haz the power, 2011-11-17 22:38:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8574049/3017

[commit-bot: I haz the power, 2011-11-18 00:10:38]

Change committed as 110608