Issue 8574047: Get content to build again with aura & component build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8574047: Get content to build again with aura & component build. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 1 month ago

Reviewers:
Dirk Pranke, jam

CC:
chromium-reviews, ctguil+watch_chromium.org, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, davidbarr+watch_chromium.org, jam, penghuang+watch_chromium.org, yuzo+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, James Su, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get content to build again with aura & component build. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110565

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -5 lines)			Patch
M	content/browser/accessibility/browser_accessibility.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/accessibility/browser_accessibility_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Does it make sense to just de-inline the couple of accessors in RenderWidgetHostView and then ...

9 years, 1 month ago (2011-11-17 01:19:18 UTC) #3

Ben Goodger (Google)

9 years, 1 month ago (2011-11-17 20:59:39 UTC) #4

I think in the short term jam/avi et al are working to make it so that RWHV
is not used outside content... then this class can just not be exported at
all?

-Ben

On Wed, Nov 16, 2011 at 5:19 PM, <dpranke@chromium.org> wrote:

> Does it make sense to just de-inline the couple of accessors in
> RenderWidgetHostView and then export the whole class so that you don't
> have to
> do NON_EXPORTED_BASE ?
>
> I feel like NON_EXPORTED_BASE should maybe be reserved for classes we
> don't have
> any control over.
>
>
http://codereview.chromium.**org/8574047/<http://codereview.chromium.org/8574...
>

Expand Messages | Collapse Messages