Issue 8574038: Excluding Yotube CPU perf test from continuous public runs

Issue 8574038: Excluding Yotube CPU perf test from continuous public runs (Closed)

Created:
9 years, 1 month ago by rohitbm

Modified:
9 years, 1 month ago

Reviewers:
krisr, Nirnimesh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/test/

Visibility:
Public.

More Reviews

Description

Since this test uses private API, excluding this test from continuous public runs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110370

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	functional/PYAUTO_TESTS	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/8574038/diff/1/functional/PYAUTO_TESTS File functional/PYAUTO_TESTS (right): http://codereview.chromium.org/8574038/diff/1/functional/PYAUTO_TESTS#newcode434 functional/PYAUTO_TESTS:434: '-perf.YoutubePerfTest.testYoutubeCPU', Wait. where is this enabled?

9 years, 1 month ago (2011-11-16 22:25:48 UTC) #3

rohitbm

On 2011/11/16 22:25:48, Nirnimesh wrote: > http://codereview.chromium.org/8574038/diff/1/functional/PYAUTO_TESTS > File functional/PYAUTO_TESTS (right): > > http://codereview.chromium.org/8574038/diff/1/functional/PYAUTO_TESTS#newcode434 > ...

9 years, 1 month ago (2011-11-16 22:29:27 UTC) #4

Nirnimesh

9 years, 1 month ago (2011-11-16 22:31:56 UTC) #5

CONTINUOUS_PUBLIC does not include CHROMEOS_PERF in the first place.
You should not need to exclude any of the 'perf' tests in CONTINUOUS_PUBLIC

On Wed, Nov 16, 2011 at 2:29 PM, <rohitbm@chromium.org> wrote:

> On 2011/11/16 22:25:48, Nirnimesh wrote:
>
>>
http://codereview.chromium.**org/8574038/diff/1/functional/**PYAUTO_TESTS<htt...
>> File functional/PYAUTO_TESTS (right):
>>
>
>
> http://codereview.chromium.**org/8574038/diff/1/functional/**
>
PYAUTO_TESTS#newcode434<http://codereview.chromium.org/8574038/diff/1/functional/PYAUTO_TESTS#newcode434>
>
>> functional/PYAUTO_TESTS:434: '-perf.YoutubePerfTest.**testYoutubeCPU',
>> Wait. where is this enabled?
>>
>
> 603   'CHROMEOS_PERF': {
> 604     'chromeos': [
> 605       'perf',
> 606     ],
> 607   },
>
>
>
http://codereview.chromium.**org/8574038/<http://codereview.chromium.org/8574...
>



-- 
../NiR

Expand Messages | Collapse Messages