src/hydrogen.cc - Issue 8574036: Re-added missing return in HInferRepresentation::TryChange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 8574036: Re-added missing return in HInferRepresentation::TryChange. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 4b7528b596f6f02b78cdbcb33d59aa015146a09f..d0380c44b116320118fd8ae6c644dc3de4b596a1 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -1678,7 +1678,7 @@ Representation HInferRepresentation::TryChange(HValue* value) {

}

// Prefer unboxing over boxing, the latter is more expensive.

- if (tagged_count > non_tagged_count) Representation::None();

+ if (tagged_count > non_tagged_count) return Representation::None();

// Prefer Integer32 over Double, if possible.

if (int32_count > 0 && value->IsConvertibleToInteger()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »