Issue 8574033: Beginnings of Window Modality support.

Issue 8574033: Beginnings of Window Modality support. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Beginnings of Window Modality support. http://crbug.com/93936 TEST=none yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110326

Patch Set 4 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+836 lines, -42 lines)			Patch
M	ui/aura/client/aura_constants.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura/client/aura_constants.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/window.cc	View	1 2	1 chunk	+7 lines, -5 lines	0 comments	Download
M	ui/aura_shell/aura_shell.gyp	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/aura_shell/desktop_event_filter.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/desktop_event_filter.cc	View	1	2 chunks	+10 lines, -12 lines	0 comments	Download
M	ui/aura_shell/examples/aura_shell_main.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	ui/aura_shell/examples/window_type_launcher.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura_shell/examples/window_type_launcher.cc	View	1	4 chunks	+137 lines, -1 line	0 comments	Download
A	ui/aura_shell/modal_container_layout_manager.h	View	1 2	1 chunk	+102 lines, -0 lines	0 comments	Download
A	ui/aura_shell/modal_container_layout_manager.cc	View	1 2	1 chunk	+192 lines, -0 lines	0 comments	Download
A	ui/aura_shell/modal_container_layout_manager_unittest.cc	View	1 2	1 chunk	+173 lines, -0 lines	0 comments	Download
A	ui/aura_shell/modality_event_filter.h	View	1 2	1 chunk	+42 lines, -0 lines	0 comments	Download
A	ui/aura_shell/modality_event_filter.cc	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
A	ui/aura_shell/modality_event_filter_delegate.h	View	1 2	1 chunk	+27 lines, -0 lines	0 comments	Download
M	ui/aura_shell/shell.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura_shell/shell.cc	View	1 2	3 chunks	+21 lines, -0 lines	0 comments	Download
M	ui/aura_shell/shell_factory.h	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	ui/aura_shell/shell_window_ids.h	View	1 2	1 chunk	+6 lines, -3 lines	0 comments	Download
M	ui/aura_shell/stacking_controller.cc	View	1 2	3 chunks	+11 lines, -1 line	0 comments	Download
M	ui/aura_shell/status_area_view.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/toplevel_layout_manager_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura_shell/workspace/workspace.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/workspace_controller.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/resource/resource_bundle.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/resource/resource_bundle.cc	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	ui/gfx/compositor/compositor.gyp	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	ui/views/window/custom_frame_view.cc	View	1	2 chunks	+18 lines, -3 lines	0 comments	Download
M	views/widget/native_widget_aura.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	views/widget/tooltip_manager_views.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/8574033/diff/8001/ui/aura_shell/modality_event_filter.cc File ui/aura_shell/modality_event_filter.cc (right): http://codereview.chromium.org/8574033/diff/8001/ui/aura_shell/modality_event_filter.cc#newcode25 ui/aura_shell/modality_event_filter.cc:25: bool ModalityEventFilter::PreHandleMouseEvent(aura::Window* target, nit: newline between 24 and 25. ...

9 years, 1 month ago (2011-11-16 17:13:06 UTC) #2

sky

9 years, 1 month ago (2011-11-16 17:40:46 UTC) #3

LGTM

http://codereview.chromium.org/8574033/diff/20001/ui/aura_shell/aura_shell.gyp
File ui/aura_shell/aura_shell.gyp (right):

http://codereview.chromium.org/8574033/diff/20001/ui/aura_shell/aura_shell.gy...
ui/aura_shell/aura_shell.gyp:88: 'modal_container_layout_manager.cc',
nit: sort

http://codereview.chromium.org/8574033/diff/20001/ui/aura_shell/aura_shell.gy...
ui/aura_shell/aura_shell.gyp:139: 'modal_container_layout_manager_unittest.cc',
nit: sort

Expand Messages | Collapse Messages