Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/browser/ui/webui/print_preview_handler_unittest.cc

Issue 8574028: Disable PrintPreviewHandlerTests on CrOS. They are crashing. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_writer.h" 6 #include "base/json/json_writer.h"
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/printing/background_printing_manager.h" 9 #include "chrome/browser/printing/background_printing_manager.h"
10 #include "chrome/browser/printing/print_preview_tab_controller.h" 10 #include "chrome/browser/printing/print_preview_tab_controller.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 private: 142 private:
143 void ClearStickySettings() { 143 void ClearStickySettings() {
144 PrintPreviewHandler::last_used_margins_type_ = printing::DEFAULT_MARGINS; 144 PrintPreviewHandler::last_used_margins_type_ = printing::DEFAULT_MARGINS;
145 delete PrintPreviewHandler::last_used_page_size_margins_; 145 delete PrintPreviewHandler::last_used_page_size_margins_;
146 PrintPreviewHandler::last_used_page_size_margins_ = NULL; 146 PrintPreviewHandler::last_used_page_size_margins_ = NULL;
147 } 147 }
148 }; 148 };
149 149
150 // Test crashs on TouchUI due to initiator tab's native view having no parent. 150 // Test crashs on TouchUI due to initiator tab's native view having no parent.
151 // http://crbug.com/104284 151 // http://crbug.com/104284
152 #if defined(TOUCH_UI) 152 // Test crashes on CrOS as well. http://crbug.com/104403
153 #if defined(TOUCH_UI) || defined(OS_CHROMEOS)
153 #define MAYBE_StickyMarginsCustom DISABLED_StickyMarginsCustom 154 #define MAYBE_StickyMarginsCustom DISABLED_StickyMarginsCustom
154 #else 155 #else
155 #define MAYBE_StickyMarginsCustom StickyMarginsCustom 156 #define MAYBE_StickyMarginsCustom StickyMarginsCustom
156 #endif 157 #endif
157 // Tests that margin settings are saved correctly when printing with custom 158 // Tests that margin settings are saved correctly when printing with custom
158 // margins selected. 159 // margins selected.
159 TEST_F(PrintPreviewHandlerTest, MAYBE_StickyMarginsCustom) { 160 TEST_F(PrintPreviewHandlerTest, MAYBE_StickyMarginsCustom) {
160 const double kMarginTop = 25.5; 161 const double kMarginTop = 25.5;
161 const double kMarginRight = 26.5; 162 const double kMarginRight = 26.5;
162 const double kMarginBottom = 27.5; 163 const double kMarginBottom = 27.5;
163 const double kMarginLeft = 28.5; 164 const double kMarginLeft = 28.5;
164 RequestPrintWithCustomMargins( 165 RequestPrintWithCustomMargins(
165 kMarginTop, kMarginRight, kMarginBottom, kMarginLeft); 166 kMarginTop, kMarginRight, kMarginBottom, kMarginLeft);
166 EXPECT_EQ(1, browser()->tab_count()); 167 EXPECT_EQ(1, browser()->tab_count());
167 168
168 // Checking that sticky settings were saved correctly. 169 // Checking that sticky settings were saved correctly.
169 EXPECT_EQ(PrintPreviewHandler::last_used_color_model_, printing::COLOR); 170 EXPECT_EQ(PrintPreviewHandler::last_used_color_model_, printing::COLOR);
170 EXPECT_EQ(PrintPreviewHandler::last_used_margins_type_, 171 EXPECT_EQ(PrintPreviewHandler::last_used_margins_type_,
171 printing::CUSTOM_MARGINS); 172 printing::CUSTOM_MARGINS);
172 ASSERT_TRUE(PrintPreviewHandler::last_used_page_size_margins_); 173 ASSERT_TRUE(PrintPreviewHandler::last_used_page_size_margins_);
173 CheckCustomMargins(kMarginTop, kMarginRight, kMarginBottom, kMarginLeft); 174 CheckCustomMargins(kMarginTop, kMarginRight, kMarginBottom, kMarginLeft);
174 } 175 }
175 176
176 // http://crbug.com/104284 177 // http://crbug.com/104284, http://crbug.com/104403
177 #if defined(TOUCH_UI) 178 #if defined(TOUCH_UI) || defined(OS_CHROMEOS)
178 #define MAYBE_StickyMarginsDefault DISABLED_StickyMarginsDefault 179 #define MAYBE_StickyMarginsDefault DISABLED_StickyMarginsDefault
179 #else 180 #else
180 #define MAYBE_StickyMarginsDefault StickyMarginsDefault 181 #define MAYBE_StickyMarginsDefault StickyMarginsDefault
181 #endif 182 #endif
182 // Tests that margin settings are saved correctly when printing with default 183 // Tests that margin settings are saved correctly when printing with default
183 // margins selected. 184 // margins selected.
184 TEST_F(PrintPreviewHandlerTest, MAYBE_StickyMarginsDefault) { 185 TEST_F(PrintPreviewHandlerTest, MAYBE_StickyMarginsDefault) {
185 RequestPrintWithDefaultMargins(); 186 RequestPrintWithDefaultMargins();
186 EXPECT_EQ(1, browser()->tab_count()); 187 EXPECT_EQ(1, browser()->tab_count());
187 188
188 // Checking that sticky settings were saved correctly. 189 // Checking that sticky settings were saved correctly.
189 EXPECT_EQ(PrintPreviewHandler::last_used_color_model_, printing::COLOR); 190 EXPECT_EQ(PrintPreviewHandler::last_used_color_model_, printing::COLOR);
190 EXPECT_EQ(PrintPreviewHandler::last_used_margins_type_, 191 EXPECT_EQ(PrintPreviewHandler::last_used_margins_type_,
191 printing::DEFAULT_MARGINS); 192 printing::DEFAULT_MARGINS);
192 ASSERT_FALSE(PrintPreviewHandler::last_used_page_size_margins_); 193 ASSERT_FALSE(PrintPreviewHandler::last_used_page_size_margins_);
193 } 194 }
194 195
195 // http://crbug.com/104284 196 // http://crbug.com/104284, http://crbug.com/104403
196 #if defined(TOUCH_UI) 197 #if defined(TOUCH_UI) || defined(OS_CHROMEOS)
197 #define MAYBE_StickyMarginsCustomThenDefault \ 198 #define MAYBE_StickyMarginsCustomThenDefault \
198 DISABLED_StickyMarginsCustomThenDefault 199 DISABLED_StickyMarginsCustomThenDefault
199 #else 200 #else
200 #define MAYBE_StickyMarginsCustomThenDefault StickyMarginsCustomThenDefault 201 #define MAYBE_StickyMarginsCustomThenDefault StickyMarginsCustomThenDefault
201 #endif 202 #endif
202 // Tests that margin settings are saved correctly when printing with custom 203 // Tests that margin settings are saved correctly when printing with custom
203 // margins selected and then again with default margins selected. 204 // margins selected and then again with default margins selected.
204 TEST_F(PrintPreviewHandlerTest, MAYBE_StickyMarginsCustomThenDefault) { 205 TEST_F(PrintPreviewHandlerTest, MAYBE_StickyMarginsCustomThenDefault) {
205 const double kMarginTop = 125.5; 206 const double kMarginTop = 125.5;
206 const double kMarginRight = 126.5; 207 const double kMarginRight = 126.5;
(...skipping 12 matching lines...) Expand all
219 RequestPrintWithDefaultMargins(); 220 RequestPrintWithDefaultMargins();
220 221
221 // Checking that sticky settings were saved correctly. 222 // Checking that sticky settings were saved correctly.
222 EXPECT_EQ(PrintPreviewHandler::last_used_color_model_, printing::COLOR); 223 EXPECT_EQ(PrintPreviewHandler::last_used_color_model_, printing::COLOR);
223 EXPECT_EQ(PrintPreviewHandler::last_used_margins_type_, 224 EXPECT_EQ(PrintPreviewHandler::last_used_margins_type_,
224 printing::DEFAULT_MARGINS); 225 printing::DEFAULT_MARGINS);
225 ASSERT_TRUE(PrintPreviewHandler::last_used_page_size_margins_); 226 ASSERT_TRUE(PrintPreviewHandler::last_used_page_size_margins_);
226 CheckCustomMargins(kMarginTop, kMarginRight, kMarginBottom, kMarginLeft); 227 CheckCustomMargins(kMarginTop, kMarginRight, kMarginBottom, kMarginLeft);
227 } 228 }
228 229
229 // http://crbug.com/104284 230 // http://crbug.com/104284, http://crbug.com/104403
230 #if defined(TOUCH_UI) 231 #if defined(TOUCH_UI) || defined(OS_CHROMEOS)
231 #define MAYBE_GetLastUsedMarginSettingsCustom \ 232 #define MAYBE_GetLastUsedMarginSettingsCustom \
232 DISABLED_GetLastUsedMarginSettingsCustom 233 DISABLED_GetLastUsedMarginSettingsCustom
233 #else 234 #else
234 #define MAYBE_GetLastUsedMarginSettingsCustom GetLastUsedMarginSettingsCustom 235 #define MAYBE_GetLastUsedMarginSettingsCustom GetLastUsedMarginSettingsCustom
235 #endif 236 #endif
236 // Tests that margin settings are retrieved correctly after printing with custom 237 // Tests that margin settings are retrieved correctly after printing with custom
237 // margins. 238 // margins.
238 TEST_F(PrintPreviewHandlerTest, MAYBE_GetLastUsedMarginSettingsCustom) { 239 TEST_F(PrintPreviewHandlerTest, MAYBE_GetLastUsedMarginSettingsCustom) {
239 const double kMarginTop = 125.5; 240 const double kMarginTop = 125.5;
240 const double kMarginRight = 126.5; 241 const double kMarginRight = 126.5;
(...skipping 15 matching lines...) Expand all
256 &margin_value)); 257 &margin_value));
257 EXPECT_EQ(kMarginRight, margin_value); 258 EXPECT_EQ(kMarginRight, margin_value);
258 EXPECT_TRUE(initial_settings.GetDouble(printing::kSettingMarginBottom, 259 EXPECT_TRUE(initial_settings.GetDouble(printing::kSettingMarginBottom,
259 &margin_value)); 260 &margin_value));
260 EXPECT_EQ(kMarginBottom, margin_value); 261 EXPECT_EQ(kMarginBottom, margin_value);
261 EXPECT_TRUE(initial_settings.GetDouble(printing::kSettingMarginLeft, 262 EXPECT_TRUE(initial_settings.GetDouble(printing::kSettingMarginLeft,
262 &margin_value)); 263 &margin_value));
263 EXPECT_EQ(kMarginLeft, margin_value); 264 EXPECT_EQ(kMarginLeft, margin_value);
264 } 265 }
265 266
266 // http://crbug.com/104284 267 // http://crbug.com/104284, http://crbug.com/104403
267 #if defined(TOUCH_UI) 268 #if defined(TOUCH_UI) || defined(OS_CHROMEOS)
268 #define MAYBE_GetLastUsedMarginSettingsDefault \ 269 #define MAYBE_GetLastUsedMarginSettingsDefault \
269 DISABLED_GetLastUsedMarginSettingsDefault 270 DISABLED_GetLastUsedMarginSettingsDefault
270 #else 271 #else
271 #define MAYBE_GetLastUsedMarginSettingsDefault GetLastUsedMarginSettingsDefault 272 #define MAYBE_GetLastUsedMarginSettingsDefault GetLastUsedMarginSettingsDefault
272 #endif 273 #endif
273 // Tests that margin settings are retrieved correctly after printing with 274 // Tests that margin settings are retrieved correctly after printing with
274 // default margins. 275 // default margins.
275 TEST_F(PrintPreviewHandlerTest, MAYBE_GetLastUsedMarginSettingsDefault) { 276 TEST_F(PrintPreviewHandlerTest, MAYBE_GetLastUsedMarginSettingsDefault) {
276 RequestPrintWithDefaultMargins(); 277 RequestPrintWithDefaultMargins();
277 base::DictionaryValue initial_settings; 278 base::DictionaryValue initial_settings;
278 preview_ui_->handler_->GetLastUsedMarginSettings(&initial_settings); 279 preview_ui_->handler_->GetLastUsedMarginSettings(&initial_settings);
279 int margins_type; 280 int margins_type;
280 EXPECT_TRUE(initial_settings.GetInteger(printing::kSettingMarginsType, 281 EXPECT_TRUE(initial_settings.GetInteger(printing::kSettingMarginsType,
281 &margins_type)); 282 &margins_type));
282 EXPECT_EQ(margins_type, printing::DEFAULT_MARGINS); 283 EXPECT_EQ(margins_type, printing::DEFAULT_MARGINS);
283 double margin_value; 284 double margin_value;
284 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginTop, 285 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginTop,
285 &margin_value)); 286 &margin_value));
286 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginRight, 287 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginRight,
287 &margin_value)); 288 &margin_value));
288 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginBottom, 289 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginBottom,
289 &margin_value)); 290 &margin_value));
290 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginLeft, 291 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginLeft,
291 &margin_value)); 292 &margin_value));
292 } 293 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698