Refactor client channel dispatchers.

remoting/protocol/client_control_dispatcher.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/protocol/client_control_dispatcher.h"
+
+#include "base/memory/ref_counted.h"
+#include "base/message_loop_proxy.h"
+#include "net/base/io_buffer.h"
+#include "remoting/proto/control.pb.h"
+#include "remoting/proto/event.pb.h"
+#include "remoting/proto/internal.pb.h"
+#include "remoting/protocol/client_stub.h"
+#include "remoting/protocol/input_stub.h"
+#include "remoting/protocol/message_reader.h"
+#include "remoting/protocol/session.h"
+
+namespace remoting {
+namespace protocol {
+
+ClientControlDispatcher::ClientControlDispatcher()
+    : client_stub_(NULL),
+      writer_(new BufferedSocketWriter(base::MessageLoopProxy::current())) {
+}
+
+ClientControlDispatcher::~ClientControlDispatcher() {
+  writer_->Close();
+}
+
+void ClientControlDispatcher::Init(protocol::Session* session) {
+  DCHECK(session);
+
+  // TODO(garykac): Set write failed callback.
+  writer_->Init(session->control_channel(),
+                BufferedSocketWriter::WriteFailedCallback());
+  reader_.Init(session->control_channel(), base::Bind(
+      &ClientControlDispatcher::OnMessageReceived, base::Unretained(this)));
+}
+
+void ClientControlDispatcher::OnMessageReceived(
+    ControlMessage* message, const base::Closure& done_task) {
+  DCHECK(client_stub_);
+
+  if (message->has_begin_session_deprecated()) {
+    // Host sends legacy BeginSession message for compatibility with
+    // older clients. Ignore it.

[Wez, 2011/11/17 22:30:22]

nit: Ignore it without warning.

[Sergey Ulanov, 2011/11/17 22:48:08]

Done.

+  } else {
+    LOG(WARNING) << "Unknown control message received.";
+  }
+  done_task.Run();

[Wez, 2011/11/17 22:30:22]

nit: Use a ScopedClosureRunner so that future changes to this function are less
likely to break things?

[Sergey Ulanov, 2011/11/17 22:48:08]

Done.

+}
+
+}  // namespace protocol
+}  // namespace remoting