Refactor client channel dispatchers.

remoting/protocol/client_control_dispatcher.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_PROTOCOL_CLIENT_CONTROL_DISPATCHER_H_
+#define REMOTING_PROTOCOL_CLIENT_CONTROL_DISPATCHER_H_
+
+#include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
+#include "remoting/protocol/host_stub.h"
+#include "remoting/protocol/message_reader.h"
+
+namespace base {
+class MessageLoopProxy;
+}  // namespace base
+
+namespace remoting {
+namespace protocol {
+
+class ClientStub;
+class ControlMessage;
+class BufferedSocketWriter;
+class Session;
+
+// ClientControlDispatcher manages control channel on the client

[Wez, 2011/11/17 01:51:56]

typo: manages _the_ control channel

Although I think this comment could just become:

ClientControlDispatcher dispatches control messages from the Host to the
ClientStub, and implements the HostStub interface to write messages to the
control channel.

[Sergey Ulanov, 2011/11/17 19:29:06]

Done.

+// side. It dispatches incoming messages on the control channel to
+// ClientStub, and also implements HostStub for outgoing messages.

[Wez, 2011/11/17 01:51:56]

I think perhaps ClientStub and HostStub need renaming, probably in a follow-up
CL.

[Sergey Ulanov, 2011/11/17 19:29:06]

Agree. Any suggestions for new names?

+class ClientControlDispatcher : public HostStub {
+ public:
+  // Construct a message dispatcher.

[Wez, 2011/11/17 01:51:56]

What is the |message_loop| parameter used for?

[Sergey Ulanov, 2011/11/17 19:29:06]

Removed this comment and |message_loop|

+  ClientControlDispatcher(base::MessageLoopProxy* message_loop);

[Wez, 2011/11/17 01:51:56]

Why is the |message_loop| supplied to the ctor, rather than to Init()?

[Wez, 2011/11/17 01:51:56]

Missing explicit here.

[Sergey Ulanov, 2011/11/17 19:29:06]

Done.

[Sergey Ulanov, 2011/11/17 19:29:06]

not needed anymore

+  virtual ~ClientControlDispatcher();
+
+  // Initialize the message dispatcher with the given connection and
+  // message handlers.

[Wez, 2011/11/17 01:51:56]

Who owns them?

[Sergey Ulanov, 2011/11/17 19:29:06]

Done.

+  void Init(protocol::Session* session, ClientStub* client_stub);
+
+  void Close();

[Wez, 2011/11/17 01:51:56]

What does this do?  Who uses it?

[Sergey Ulanov, 2011/11/17 19:29:06]

Done.

+
+ private:
+  void OnMessageReceived(ControlMessage* message,
+                         const base::Closure& done_task);
+
+  ClientStub* client_stub_;
+
+  ProtobufMessageReader<ControlMessage> reader_;
+  scoped_refptr<BufferedSocketWriter> writer_;
+
+  DISALLOW_COPY_AND_ASSIGN(ClientControlDispatcher);
+};
+
+}  // namespace protocol
+}  // namespace remoting
+
+#endif  // REMOTING_PROTOCOL_CLIENT_CONTROL_DISPATCHER_H_