Issue 8574017: Consolidate rendering of gray segmented spinner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8574017: Consolidate rendering of gray segmented spinner. (Closed)

Created:
9 years, 1 month ago by kevers

Modified:
9 years, 1 month ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Consolidate rendering of gray segmented spinner. BUG=chromium-os:21999 TEST=Starting with a clean profile, launch ChromeOS and proceed through the steps of setting up a new login profile. Expect spinners to be gray. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110699

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -109 lines)			Patch
M	chrome/browser/resources/chromeos/login/login.html	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.html	View	2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/chromeos/login/spinner.css	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	chrome/browser/resources/shared/css/spinner.css	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/shared/images/spinner.svg	View	1 chunk	+73 lines, -74 lines	0 comments	Download

Total messages: 5 (0 generated)

kevers

Hi Nikita, Can you please have a look at this change. It updates the spinners ...

9 years, 1 month ago (2011-11-15 22:16:10 UTC) #1

Nikita (slow)

On 2011/11/15 22:16:10, kevers wrote: > The change does not address any C++ code using ...

9 years, 1 month ago (2011-11-16 12:56:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/8574017/6001

9 years, 1 month ago (2011-11-18 13:41:54 UTC) #4

Change committed as 110699