Issue 8574008: Revert 109982 - Roll clang 143497:144521

Issue 8574008: Revert 109982 - Roll clang 143497:144521 (Closed)

Created:
9 years, 1 month ago by Jói

Modified:
9 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews, fischman+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 109982 - Roll clang 143497:144521 Reason: Was causing Clang crashes on Google Chrome Mac official builder, e.g. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/5731) Linux directory detection is now done in the driver instead of in the frontend, so let the plugin test script invoke the driver instead of clang -cc1 (else it won't find <string> etc on linux). BUG=none TEST=none TBR=hans Review URL: http://codereview.chromium.org/8538027 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110101

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/clang/plugins/tests/test.sh	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	tools/clang/scripts/update.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói

This is a speculative revert, but looks like the only likely cause for the crashes. ...

9 years, 1 month ago (2011-11-15 16:40:27 UTC) #2

This is a speculative revert, but looks like the only likely cause for
the crashes.

Nico messaged me to let me know it is actually safe to revert a Clang
roll; it's only when going forward that you need to do various extra
stuff.

Cheers,
Jói


On Tue, Nov 15, 2011 at 4:36 PM,  <joi@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Revert 109982 - Roll clang 143497:144521
>
> Reason: Was causing Clang crashes on Google Chrome Mac official
> builder,
> e.g.
>
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...)
>
> Linux directory detection is now done in the driver instead of in the
> frontend, so let the plugin test script invoke the driver instead of
> clang -cc1 (else it won't find <string> etc on linux).
>
> BUG=none
> TEST=none
> TBR=hans
>
> Review URL: http://codereview.chromium.org/8538027
>
> TBR=thakis@chromium.org
>
> Please review this at http://codereview.chromium.org/8574008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/clang/plugins/tests/test.sh
>  M     tools/clang/scripts/update.sh
>
>
> Index: tools/clang/plugins/tests/test.sh
> ===================================================================
> --- tools/clang/plugins/tests/test.sh   (revision 110100)
> +++ tools/clang/plugins/tests/test.sh   (working copy)
> @@ -23,9 +23,9 @@
>
>  # Runs a single test case.
>  do_testcase() {
> -  local output="$("${CLANG_DIR}"/bin/clang -c \
> -      -Xclang -load -Xclang "${CLANG_DIR}"/lib/libFindBadConstructs.${LIB}
> \
> -      -Xclang -plugin -Xclang find-bad-constructs ${1} 2>&1)"
> +  local output="$("${CLANG_DIR}"/bin/clang -cc1 \
> +      -load "${CLANG_DIR}"/lib/libFindBadConstructs.${LIB} \
> +      -plugin find-bad-constructs ${1} 2>&1)"
>   local diffout="$(echo "${output}" | diff - "${2}")"
>   if [ "${diffout}" = "" ]; then
>     echo "PASS: ${1}"
> Index: tools/clang/scripts/update.sh
> ===================================================================
> --- tools/clang/scripts/update.sh       (revision 110100)
> +++ tools/clang/scripts/update.sh       (working copy)
> @@ -7,7 +7,7 @@
>
>  # Do NOT CHANGE this if you don't know what you're doing -- see
>  # http://code.google.com/p/chromium/wiki/UpdatingClang
> -CLANG_REVISION=144521
> +CLANG_REVISION=143497
>
>  THIS_DIR="$(dirname "${0}")"
>  LLVM_DIR="${THIS_DIR}/../../../third_party/llvm"
>
>
>

Nico

lgtm On Tue, Nov 15, 2011 at 8:39 AM, Jói Sigurðsson <joi@chromium.org> wrote: > This ...

9 years, 1 month ago (2011-11-15 17:02:42 UTC) #3

lgtm

On Tue, Nov 15, 2011 at 8:39 AM, Jói Sigurðsson <joi@chromium.org> wrote:
> This is a speculative revert, but looks like the only likely cause for
> the crashes.
>
> Nico messaged me to let me know it is actually safe to revert a Clang
> roll; it's only when going forward that you need to do various extra
> stuff.
>
> Cheers,
> Jói
>
>
> On Tue, Nov 15, 2011 at 4:36 PM,  <joi@chromium.org> wrote:
>> Reviewers: Nico,
>>
>> Description:
>> Revert 109982 - Roll clang 143497:144521
>>
>> Reason: Was causing Clang crashes on Google Chrome Mac official
>> builder,
>> e.g.
>>
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...)
>>
>> Linux directory detection is now done in the driver instead of in the
>> frontend, so let the plugin test script invoke the driver instead of
>> clang -cc1 (else it won't find <string> etc on linux).
>>
>> BUG=none
>> TEST=none
>> TBR=hans
>>
>> Review URL: http://codereview.chromium.org/8538027
>>
>> TBR=thakis@chromium.org
>>
>> Please review this at http://codereview.chromium.org/8574008/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>  M     tools/clang/plugins/tests/test.sh
>>  M     tools/clang/scripts/update.sh
>>
>>
>> Index: tools/clang/plugins/tests/test.sh
>> ===================================================================
>> --- tools/clang/plugins/tests/test.sh   (revision 110100)
>> +++ tools/clang/plugins/tests/test.sh   (working copy)
>> @@ -23,9 +23,9 @@
>>
>>  # Runs a single test case.
>>  do_testcase() {
>> -  local output="$("${CLANG_DIR}"/bin/clang -c \
>> -      -Xclang -load -Xclang "${CLANG_DIR}"/lib/libFindBadConstructs.${LIB}
>> \
>> -      -Xclang -plugin -Xclang find-bad-constructs ${1} 2>&1)"
>> +  local output="$("${CLANG_DIR}"/bin/clang -cc1 \
>> +      -load "${CLANG_DIR}"/lib/libFindBadConstructs.${LIB} \
>> +      -plugin find-bad-constructs ${1} 2>&1)"
>>   local diffout="$(echo "${output}" | diff - "${2}")"
>>   if [ "${diffout}" = "" ]; then
>>     echo "PASS: ${1}"
>> Index: tools/clang/scripts/update.sh
>> ===================================================================
>> --- tools/clang/scripts/update.sh       (revision 110100)
>> +++ tools/clang/scripts/update.sh       (working copy)
>> @@ -7,7 +7,7 @@
>>
>>  # Do NOT CHANGE this if you don't know what you're doing -- see
>>  # http://code.google.com/p/chromium/wiki/UpdatingClang
>> -CLANG_REVISION=144521
>> +CLANG_REVISION=143497
>>
>>  THIS_DIR="$(dirname "${0}")"
>>  LLVM_DIR="${THIS_DIR}/../../../third_party/llvm"
>>
>>
>>
>

Nico

9 years, 1 month ago (2011-11-15 17:03:02 UTC) #4

I'm tracking the problem at http://crbug.com/104323

On Tue, Nov 15, 2011 at 9:02 AM, Nico Weber <thakis@chromium.org> wrote:
> lgtm
>
> On Tue, Nov 15, 2011 at 8:39 AM, Jói Sigurðsson <joi@chromium.org> wrote:
>> This is a speculative revert, but looks like the only likely cause for
>> the crashes.
>>
>> Nico messaged me to let me know it is actually safe to revert a Clang
>> roll; it's only when going forward that you need to do various extra
>> stuff.
>>
>> Cheers,
>> Jói
>>
>>
>> On Tue, Nov 15, 2011 at 4:36 PM,  <joi@chromium.org> wrote:
>>> Reviewers: Nico,
>>>
>>> Description:
>>> Revert 109982 - Roll clang 143497:144521
>>>
>>> Reason: Was causing Clang crashes on Google Chrome Mac official
>>> builder,
>>> e.g.
>>>
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...)
>>>
>>> Linux directory detection is now done in the driver instead of in the
>>> frontend, so let the plugin test script invoke the driver instead of
>>> clang -cc1 (else it won't find <string> etc on linux).
>>>
>>> BUG=none
>>> TEST=none
>>> TBR=hans
>>>
>>> Review URL: http://codereview.chromium.org/8538027
>>>
>>> TBR=thakis@chromium.org
>>>
>>> Please review this at http://codereview.chromium.org/8574008/
>>>
>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>>
>>> Affected files:
>>>  M     tools/clang/plugins/tests/test.sh
>>>  M     tools/clang/scripts/update.sh
>>>
>>>
>>> Index: tools/clang/plugins/tests/test.sh
>>> ===================================================================
>>> --- tools/clang/plugins/tests/test.sh   (revision 110100)
>>> +++ tools/clang/plugins/tests/test.sh   (working copy)
>>> @@ -23,9 +23,9 @@
>>>
>>>  # Runs a single test case.
>>>  do_testcase() {
>>> -  local output="$("${CLANG_DIR}"/bin/clang -c \
>>> -      -Xclang -load -Xclang "${CLANG_DIR}"/lib/libFindBadConstructs.${LIB}
>>> \
>>> -      -Xclang -plugin -Xclang find-bad-constructs ${1} 2>&1)"
>>> +  local output="$("${CLANG_DIR}"/bin/clang -cc1 \
>>> +      -load "${CLANG_DIR}"/lib/libFindBadConstructs.${LIB} \
>>> +      -plugin find-bad-constructs ${1} 2>&1)"
>>>   local diffout="$(echo "${output}" | diff - "${2}")"
>>>   if [ "${diffout}" = "" ]; then
>>>     echo "PASS: ${1}"
>>> Index: tools/clang/scripts/update.sh
>>> ===================================================================
>>> --- tools/clang/scripts/update.sh       (revision 110100)
>>> +++ tools/clang/scripts/update.sh       (working copy)
>>> @@ -7,7 +7,7 @@
>>>
>>>  # Do NOT CHANGE this if you don't know what you're doing -- see
>>>  # http://code.google.com/p/chromium/wiki/UpdatingClang
>>> -CLANG_REVISION=144521
>>> +CLANG_REVISION=143497
>>>
>>>  THIS_DIR="$(dirname "${0}")"
>>>  LLVM_DIR="${THIS_DIR}/../../../third_party/llvm"
>>>
>>>
>>>
>>
>

Expand Messages | Collapse Messages