Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: runtime/bin/process_win.cc

Issue 8574002: Handle stdin/stdout/stderr on Windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments from ager@ Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/eventhandler_win.cc ('k') | runtime/bin/socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_win.cc
diff --git a/runtime/bin/process_win.cc b/runtime/bin/process_win.cc
index cfe29873afbc6ac4951c2119557037904f5c9c1f..965f43728f3ac6f7a969fdc785f5cc9bc9180c9f 100644
--- a/runtime/bin/process_win.cc
+++ b/runtime/bin/process_win.cc
@@ -224,7 +224,7 @@ static unsigned int __stdcall TerminationWaitThread(void* args) {
ok = WriteFile(
process->exit_pipe(), message, sizeof(message), &written, NULL);
if (!ok || written != sizeof(message)) {
- fprintf(stderr, "FileWrite failed %d\n", GetLastError());
+ fprintf(stderr, "WriteFile failed %d\n", GetLastError());
}
return 0;
}
@@ -375,10 +375,9 @@ int Process::Start(const char* path,
uintptr_t thread_handle =
_beginthreadex(NULL, 32 * 1024, TerminationWaitThread, process, 0, &tid);
if (thread_handle == -1) {
- FATAL("Failed to start event handler thread");
+ FATAL("Failed to start process termination wait thread");
}
-
// Connect the three std streams.
FileHandle* stdin_handle = new FileHandle(stdin_handles[kWriteHandle]);
CloseHandle(stdin_handles[kReadHandle]);
« no previous file with comments | « runtime/bin/eventhandler_win.cc ('k') | runtime/bin/socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698