Implement unittest for CandidateWindowView.

Implement unittest for CandidateWindowView.

This is preparation for implementation Mozc suggest window fix.

TEST=emerge chromeos-chrome and run unit_tests
BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110492

[Seigo Nonaka, 2011-11-16 07:15:29]

Dear reviewers, I decide to implement unit test before implementing
http://codereview.chromium.org/8505051/

Please review this CL at first.

Thank you.

[Hiro Komatsu, 2011-11-16 07:40:20]

lgtm

[Seigo Nonaka, 2011-11-16 07:51:24]

Dear yusukes,

I made a patch for implementing unit tests for ChromeOS-chrome.
Please review.

Thank you.

[horo, 2011-11-16 08:41:02]

http://codereview.chromium.org/8573035/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/8573035/diff/1/chrome/chrome_tests.gypi#newcod...
chrome/chrome_tests.gypi:1271:
'browser/chromeos/input_method/candidate_window_view_unittest.cc',
This test program seems to be compiled for every environment.
Is it right?

[Seigo Nonaka, 2011-11-16 08:45:08]

http://codereview.chromium.org/8573035/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/8573035/diff/1/chrome/chrome_tests.gypi#newcod...
chrome/chrome_tests.gypi:1271:
'browser/chromeos/input_method/candidate_window_view_unittest.cc',
On 2011/11/16 08:41:02, horo wrote:
> This test program seems to be compiled for every environment.
> Is it right?
No, we can switch source set with exclude rule. Please see L2143.

[horo, 2011-11-16 08:47:04]

lgtm

http://codereview.chromium.org/8573035/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/8573035/diff/1/chrome/chrome_tests.gypi#newcod...
chrome/chrome_tests.gypi:1271:
'browser/chromeos/input_method/candidate_window_view_unittest.cc',
I'm sorry for my misunderstanding.
On 2011/11/16 08:45:08, nona1 wrote:
> On 2011/11/16 08:41:02, horo wrote:
> > This test program seems to be compiled for every environment.
> > Is it right?
> No, we can switch source set with exclude rule. Please see L2143.

[Yusuke Sato, 2011-11-17 06:07:39]

LGTM with some nits.

BTW, TEST=unittest is ambiguous (which unittest?)
Do you mean 'unit_tests'?

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window.cc:20: #include
"chrome/browser/chromeos/input_method/candidate_window_view.h"
wrong order

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/candidate_window_view.h (right):

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window_view.h:179: };
one vertical space between 179 and 180

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window_view.h:179: };
disallow copy and assign

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc
(right):

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:12:
TEST(CandidateWindowViewTest, ShouldUpdateCandidateViewsTest) {
Please add 3-4 lines of test description.

[Seigo Nonaka, 2011-11-17 07:52:49]

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window.cc:20: #include
"chrome/browser/chromeos/input_method/candidate_window_view.h"
On 2011/11/17 06:07:39, Yusuke Sato wrote:
> wrong order

Done.

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/candidate_window_view.h (right):

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window_view.h:179: };
On 2011/11/17 06:07:39, Yusuke Sato wrote:
> one vertical space between 179 and 180

Done.

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window_view.h:179: };
On 2011/11/17 06:07:39, Yusuke Sato wrote:
> disallow copy and assign

Done.

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc
(right):

http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:12:
TEST(CandidateWindowViewTest, ShouldUpdateCandidateViewsTest) {
On 2011/11/17 06:07:39, Yusuke Sato wrote:
> Please add 3-4 lines of test description.

Done.

[Yusuke Sato, 2011-11-17 10:09:53]

lgtm

On 2011/11/17 07:52:49, nona1 wrote:
>
http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
> File chrome/browser/chromeos/input_method/candidate_window.cc (right):
> 
>
http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
> chrome/browser/chromeos/input_method/candidate_window.cc:20: #include
> "chrome/browser/chromeos/input_method/candidate_window_view.h"
> On 2011/11/17 06:07:39, Yusuke Sato wrote:
> > wrong order
> 
> Done.
> 
>
http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
> File chrome/browser/chromeos/input_method/candidate_window_view.h (right):
> 
>
http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
> chrome/browser/chromeos/input_method/candidate_window_view.h:179: };
> On 2011/11/17 06:07:39, Yusuke Sato wrote:
> > one vertical space between 179 and 180
> 
> Done.
> 
>
http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
> chrome/browser/chromeos/input_method/candidate_window_view.h:179: };
> On 2011/11/17 06:07:39, Yusuke Sato wrote:
> > disallow copy and assign
> 
> Done.
> 
>
http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
> File chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc
> (right):
> 
>
http://codereview.chromium.org/8573035/diff/1/chrome/browser/chromeos/input_m...
> chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:12:
> TEST(CandidateWindowViewTest, ShouldUpdateCandidateViewsTest) {
> On 2011/11/17 06:07:39, Yusuke Sato wrote:
> > Please add 3-4 lines of test description.
> 
> Done.

[commit-bot: I haz the power, 2011-11-17 10:10:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/8573035/6002

[commit-bot: I haz the power, 2011-11-17 16:08:39]

Change committed as 110492