Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 8573033: aura: Make sure the desktop is initialized when creating a DefaultMonitorInfoProvider. (Closed)

Created:
9 years, 1 month ago by sadrul
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

aura: Make sure the desktop is initialized when creating a DefaultMonitorInfoProvider. This fixes DesktopNotificationsTest tests for aura. BUG=104408 TEST=DesktopNotificationsTest.* on aura bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110319

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
9 years, 1 month ago (2011-11-16 03:00:04 UTC) #1
sky
I tend to think this is a bug in the test code that we're not ...
9 years, 1 month ago (2011-11-16 05:04:37 UTC) #2
sadrul
Alternatively, these tests could become InProcessBrowserTest's (which does initialize the desktop in SetUp through BrowserTestBase), ...
9 years, 1 month ago (2011-11-16 05:13:57 UTC) #3
sky
Go with initialization in DesktopNotificationsTest::SetUp for now. We can expand over time if necessary.
9 years, 1 month ago (2011-11-16 17:29:34 UTC) #4
sadrul
On 2011/11/16 17:29:34, sky wrote: > Go with initialization in DesktopNotificationsTest::SetUp for now. We can ...
9 years, 1 month ago (2011-11-16 17:37:23 UTC) #5
sky
9 years, 1 month ago (2011-11-16 17:41:34 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698