Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/ui/panels/panel_manager.cc

Issue 8573030: Add delay before a panel in title only mode goes back to minimized on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index bf8f03b910719d7b5c8813e03e2acbe097a09913..f9afd8c6df36e38022ba2655d6ec0cd278b8e1f8 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -44,6 +44,8 @@ const int kMaxMillisecondsWaitForBottomBarVisibilityChange = 1000;
// See usage below.
#if defined(OS_MACOSX)
const int kMillisecondsBeforeCollapsingFromTitleOnlyState = 3000;
+#elif defined(TOOLKIT_GTK)
+const int kMillisecondsBeforeCollapsingFromTitleOnlyState = 2000;
#else
const int kMillisecondsBeforeCollapsingFromTitleOnlyState = 0;
#endif
@@ -449,6 +451,11 @@ void PanelManager::BringUpOrDownTitlebars(bool bring_up) {
// it makes it possible to hit the titlebar on OSX if Dock has Magnifying
// enabled - the panels stay up for a while after Dock magnification effect
// stops covering the panels.
+ //
+ // Another example would be taskbar in auto-hide mode on Linux. In this mode
+ // taskbar will cover the panel in title hover mode, leaving it up for a few
+ // seconds would allow the user to be able to click on it.
+ //
// Currently, no platforms use both delays.
DCHECK(task_delay_milliseconds == 0);
if (!bring_up)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698