Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 8573030: Add delay before a panel in title only mode goes back to minimized on Linux. (Closed)

Created:
9 years, 1 month ago by prasadt
Modified:
9 years, 1 month ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, jennb, jianli, dcheng
Visibility:
Public.

Description

Add delay before a panel in title only mode goes back to minimized on Linux. This makes panels usable on Linux with auto-hide taskbar. Currently panels in title only mode are obscured by the taskbar when in auto-hide mode. BUG=102719 TEST=Manual. Minimize panel. Hover and move mouse away. Panel should be in titlebar mode for a few seconds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/panels/panel_manager.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
prasadt
9 years, 1 month ago (2011-11-16 02:33:10 UTC) #1
Dmitry Titov
lgtm
9 years, 1 month ago (2011-11-16 06:40:15 UTC) #2
jennb
Drive-by... can the timeout values be the same for Mac and Linux? On Tue, Nov ...
9 years, 1 month ago (2011-11-16 17:57:10 UTC) #3
prasadt
On 2011/11/16 17:57:10, jennb wrote: > Drive-by... can the timeout values be the same for ...
9 years, 1 month ago (2011-11-16 18:01:05 UTC) #4
jennb
9 years, 1 month ago (2011-11-16 18:05:46 UTC) #5
LGTM

On Wed, Nov 16, 2011 at 10:01 AM,  <prasadt@chromium.org> wrote:
> On 2011/11/16 17:57:10, jennb wrote:
>>
>> Drive-by... can the timeout values be the same for Mac and Linux?
>
>> On Tue, Nov 15, 2011 at 10:40 PM,  <mailto:dimich@chromium.org> wrote:
>> > lgtm
>> >
>> > http://codereview.chromium.org/8573030/
>> >
>
> 3 seconds feels too long to me, that's why I changed it to 2 seconds. I
> initially changed it to 3 for Mac and Linux but talking to dimich he asked
> that
> I leave it at 3 for Mac for the moment.
>
> Prasad
>
> http://codereview.chromium.org/8573030/
>

Powered by Google App Engine
This is Rietveld 408576698