Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 8573029: Fixes regression where showing bookmark bar (or download shelf) (Closed)

Created:
9 years, 1 month ago by sky
Modified:
9 years, 1 month ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Fixes regression where showing bookmark bar (or download shelf) wouldn't do a final layout resulting in the content not laying out correctly. BUG=104082 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110320

Patch Set 1 #

Patch Set 2 : const #

Patch Set 3 : Fix compile #

Patch Set 4 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M chrome/browser/ui/views/tab_contents/native_tab_contents_container.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_views.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_views.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container.cc View 1 chunk +10 lines, -1 line 0 comments Download
M views/controls/native/native_view_host.h View 2 chunks +8 lines, -0 lines 0 comments Download
M views/controls/native/native_view_host.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
9 years, 1 month ago (2011-11-16 02:24:41 UTC) #1
Ben Goodger (Google)
GetFastResize -> const LGTM
9 years, 1 month ago (2011-11-16 03:05:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8573029/5001
9 years, 1 month ago (2011-11-16 16:49:01 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 17:46:57 UTC) #4
Change committed as 110320

Powered by Google App Engine
This is Rietveld 408576698