chromeos: Move EnableScreenLock to PowerManagerClient from PowerLibrary

chrome/browser/chromeos/dbus/power_manager_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/dbus/power_manager_client.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback.h"
+#include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "base/timer.h"
 #include "chrome/browser/chromeos/system/runtime_environment.h"
 #include "dbus/bus.h"
 #include "dbus/message.h"
 #include "dbus/object_proxy.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
+namespace {
+
+const char kLockOnIdleSuspendPath[] =
+    "/var/lib/power_manager/lock_on_idle_suspend";
+
+}  // namespace
+
 namespace chromeos {
 
 PowerSupplyStatus::PowerSupplyStatus()
     : line_power_on(false),
       battery_is_present(false),
       battery_is_full(false),
       battery_seconds_to_empty(0),
       battery_seconds_to_full(0),
       battery_percentage(0) {
 }
@@ skipping 127 matching lines @@
       OVERRIDE {
     dbus::MethodCall method_call(power_manager::kPowerManagerInterface,
                                  power_manager::kGetIdleTime);
     power_manager_proxy_->CallMethod(
         &method_call,
         dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
         base::Bind(&PowerManagerClientImpl::OnGetIdleTime,
                    weak_ptr_factory_.GetWeakPtr(), callback));
   }
 
+  virtual void EnableScreenLock(bool enable) OVERRIDE {
+    std::string config = base::StringPrintf("%d", enable);
+    file_util::WriteFile(FilePath(kLockOnIdleSuspendPath),
+                         config.c_str(),
+                         config.size());

[satorux1, 2011/11/16 00:52:49]

Let's do this somewhere else. PowerManagerClient is a D-Bus client, and not
supposed to do other things.

Per git grep 'EnableScreenLock(', there seems to be only one caller:

chrome/browser/chromeos/preferences.cc:
    CrosLibrary::Get()->GetPowerLibrary()->EnableScreenLock(

I'd suggest you to do this in the file.

[satorux1, 2011/11/16 00:55:52]

Besides, please be sure to do this in FILE thread. You cannot do file operations
on UI thread.

[satorux1, 2011/11/16 00:59:48]

I changed my mind. Putting the code in chrome/browser/chromeos/system would be
cleaner. See touchpad_settings.cc and timezone_settings.cc there.

[Simon Que, 2011/11/16 01:40:02]

Done.

[Simon Que, 2011/11/16 01:40:02]

Done.

+  }
+
  private:
   // Called when a dbus signal is initially connected.
   void SignalConnected(const std::string& interface_name,
                        const std::string& signal_name,
                        bool success) {
     LOG_IF(WARNING, !success) << "Failed to connect to signal "
                               << signal_name << ".";
   }
 
   // Called when a brightness change signal is received.
@@ skipping 137 matching lines @@
 
   virtual void RequestRestart() OVERRIDE {}
 
   virtual void RequestShutdown() OVERRIDE {}
 
   virtual void CalculateIdleTime(const CalculateIdleTimeCallback& callback)
       OVERRIDE {
     callback.Run(0);
   }
 
+  virtual void EnableScreenLock(bool enable) OVERRIDE {}
+
  private:
   void Update() {
     // We pause at 0 and 100% so that it's easier to check those conditions.
     if (pause_count_ > 1) {
       pause_count_--;
       return;
     }
 
     if (battery_percentage_ == 0 || battery_percentage_ == 100) {
       if (pause_count_) {
@@ skipping 38 matching lines @@
 
 PowerManagerClient* PowerManagerClient::Create(dbus::Bus* bus) {
   if (system::runtime_environment::IsRunningOnChromeOS()) {
     return new PowerManagerClientImpl(bus);
   } else {
     return new PowerManagerClientStubImpl();
   }
 }
 
 }  // namespace chromeos