Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: remoting/client/plugin/chromoting_scriptable_object.h

Issue 8573024: Clean up client state callback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed unused error code. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/chromoting_scriptable_object.h
diff --git a/remoting/client/plugin/chromoting_scriptable_object.h b/remoting/client/plugin/chromoting_scriptable_object.h
index 235b3e6f4c932257046898c41130366156766782..5cf34a73de3ed60959991f4170d84f02ce07ccbe 100644
--- a/remoting/client/plugin/chromoting_scriptable_object.h
+++ b/remoting/client/plugin/chromoting_scriptable_object.h
@@ -120,6 +120,8 @@ class ChromotingScriptableObject
: public pp::deprecated::ScriptableObject,
public base::SupportsWeakPtr<ChromotingScriptableObject> {
public:
+ // These state values are duplicated in the JS code. Remember to update both
+ // copies when making changes.
enum ConnectionStatus {
STATUS_UNKNOWN = 0,
STATUS_CONNECTING,
@@ -129,6 +131,8 @@ class ChromotingScriptableObject
STATUS_FAILED,
};
+ // These state values are duplicated in the JS code. Remember to update both
+ // copies when making changes.
enum ConnectionError {
ERROR_NONE = 0,
ERROR_HOST_IS_OFFLINE,
@@ -197,13 +201,13 @@ class ChromotingScriptableObject
void AddAttribute(const std::string& name, pp::Var attribute);
void AddMethod(const std::string& name, MethodHandler handler);
- void SignalConnectionInfoChange();
+ void SignalConnectionInfoChange(int status, int error);
void SignalDesktopSizeChange();
// Calls to these methods are posted to the plugin thread so that we
// call JavaScript with clean stack. This is necessary because
// JavaScript event handlers may destroy the plugin.
- void DoSignalConnectionInfoChange();
+ void DoSignalConnectionInfoChange(int status, int error);
void DoSignalDesktopSizeChange();
void DoSendIq(const std::string& message_xml);

Powered by Google App Engine
This is Rietveld 408576698